Skip to content

Commit ed9854e

Browse files
TkDodoAhmed-Labs
authored andcommitted
ref: remove deprecatedRouteProps from releases (#102880)
children becomes Outlet
1 parent a4158ff commit ed9854e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

static/app/router/routes.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1709,7 +1709,6 @@ function buildRoutes(): RouteObject[] {
17091709
{
17101710
path: ':release/',
17111711
component: make(() => import('sentry/views/releases/detail')),
1712-
deprecatedRouteProps: true,
17131712
children: [
17141713
{
17151714
index: true,
@@ -1743,7 +1742,6 @@ function buildRoutes(): RouteObject[] {
17431742
component: make(() => import('sentry/views/releases/index')),
17441743
withOrgPath: true,
17451744
children: releaseChildren,
1746-
deprecatedRouteProps: true,
17471745
},
17481746
{
17491747
path: '/releases/new-events/',

static/app/views/releases/detail/index.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {createContext, useCallback, useEffect, useMemo} from 'react';
2+
import {Outlet} from 'react-router-dom';
23
import type {Location} from 'history';
34
import pick from 'lodash/pick';
45

@@ -224,7 +225,7 @@ function ReleasesDetail({
224225
// ========================================================================
225226
// RELEASE DETAIL CONTAINER
226227
// ========================================================================
227-
function ReleasesDetailContainer({children}: {children: React.ReactNode}) {
228+
function ReleasesDetailContainer() {
228229
const params = useParams<{release: string}>();
229230
const location = useLocation();
230231
const navigate = useNavigate();
@@ -308,7 +309,9 @@ function ReleasesDetailContainer({children}: {children: React.ReactNode}) {
308309
}
309310
specificProjectSlugs={projects.map((p: ReleaseProject) => p.slug)}
310311
>
311-
<ReleasesDetail releaseMeta={releaseMeta}>{children}</ReleasesDetail>
312+
<ReleasesDetail releaseMeta={releaseMeta}>
313+
<Outlet />
314+
</ReleasesDetail>
312315
</PageFiltersContainer>
313316
);
314317
}

0 commit comments

Comments
 (0)