feat(trace-tree-node): Mitigating trace root node type guards usage #104503
+147
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 46 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
|
|
||
| const node = tree.root.findChild(n => n.value === event); | ||
| return node?.traceHeaderTitle ?? null; | ||
| return event.traceHeaderTitle ?? null; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| bodyText={getRootDuration( | ||
| props.representativeEvent.event as TraceTree.TraceEvent | ||
| )} | ||
| bodyText={getRootDuration(props.representativeEvent?.event as BaseNode | null)} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
Valid removed casting
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // in the trace for the title. | ||
| firstEvent = node; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: Uptime check priority removed from representative event selection
The old getRepresentativeTraceEvent had special early-return handling for uptime checks: if the first trace child was an uptime check, it was immediately returned as the representative event. The new findRepresentativeTraceNode removes this prioritization. Since UptimeCheck values lack parent_span_id, they fail the isRootEvent check and won't match hasPreferredOp (uptime ops aren't in ['pageload', 'navigation', 'ui.load']). In traces containing both uptime checks and other nodes like transactions, a different node may now be selected as the representative event, potentially changing trace header titles and metadata display.
Contributor
Author
There was a problem hiding this comment.
No need to return early for uptime events
gggritso
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRepresentativeTraceEventutil toTraceTree.findRepresentativeTraceNode.baseNode.childrennodes and have access to all new functionality.Also:
baseNode.isEAPEventpropertybaseNode.traceItemDatasetproperty