Skip to content

Commit 5b67665

Browse files
docs(sourcebundle): Fix incomplete sentence (#940)
The sentence, as written, is incomplete. I asked Cursor to infer what the rest of the sentence should be; this is what it proposed, giving the following justification: > Looking at the implementation, I can see that: > > 1. The `SourceBundleWriter` has a `finish` method (line 1414) that: > - Takes `self` by value (consumes the writer) > - Writes the manifest > - Finalizes the underlying `ZipWriter` > > 2. There's **no `Drop` implementation** for `SourceBundleWriter` > > 3. The example code explicitly shows calling `bundle.finish()?;` to properly flush the bundle
1 parent cd76799 commit 5b67665

File tree

1 file changed

+1
-1
lines changed
  • symbolic-debuginfo/src/sourcebundle

1 file changed

+1
-1
lines changed

symbolic-debuginfo/src/sourcebundle/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1079,7 +1079,7 @@ impl Display for SkippedFileInfo<'_> {
10791079
/// [`add_file`] to add files and finally call [`finish`] to flush the archive to
10801080
/// the underlying writer.
10811081
///
1082-
/// Note that dropping the writer
1082+
/// Note that dropping the writer without calling [`finish`] will result in an incomplete bundle.
10831083
///
10841084
/// ```no_run
10851085
/// # use std::fs::File;

0 commit comments

Comments
 (0)