Add new SpGEMM/SpGEAM interface with reuse capabilities #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
MarcelKoch
requested changes
Sep 30, 2025
Member
MarcelKoch
left a comment
MarcelKoch
left a comment
There was a problem hiding this comment.
mostly lgtm, only some smaller remarks.
Member
Author
|
@MarcelKoch I added the functionality to a benchmark, a very brief check on a 1Mx1M stencil matrix on an A2 GPU shows a roughly 1.4x speedup over normal SpGEMM |
MarcelKoch
requested changes
Oct 2, 2025
Member
MarcelKoch
left a comment
MarcelKoch
left a comment
There was a problem hiding this comment.
main question about how to construct the info object.
upsj
changed the title
Member
Author
|
I added advanced_spgemm (multiply_add) and spgeam (add_scale) interfaces, as well as reusable versions thereof with extensive tests of all the size checks and cross-executor functionality. |
MarcelKoch
requested changes
Oct 8, 2025
Member
MarcelKoch
left a comment
MarcelKoch
left a comment
There was a problem hiding this comment.
Only smaller nits left, mostly regarding the testing.
upsj
force-pushed
the
new_spgemm_interface
branch
from
5cd4586 to
b015950
Compare
MarcelKoch
approved these changes
Oct 23, 2025
upsj
added
1:ST:ready-to-merge
- add documentation to multiply_reuse_info - more strict input dimension checks - fix test comments Co-authored-by: Marcel Koch <[email protected]>
- make move operations noexcept - reorder members for consistency Co-authored-by: Marcel Koch <[email protected]>
- rename add_scale to scale_add - remove unused variables Co-authored-by: Marcel Koch <[email protected]>
upsj
force-pushed
the
new_spgemm_interface
branch
from
8c5883a to
3dcf152
Compare
This was referenced Nov 7, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new SpGEMM/SpGEAM interface that works without abusing the
LinOp::applyinterface, and a new SpGEMM kernel that operates on an existing output structure (maybe it also makes sense to expose this as a masked SpGEMM operation? The difference is similar to LU vs. ILU kernels)