Merge pull request #8321 from gitbutlerapp/refactor-commit-and-file-views

test: add and update mock backend and tests for commit changes and diff handling

Author: estib-vega

apps/desktop/src/components/v3/CommitMessageEditor.svelte

@@ -16,7 +16,6 @@
 	import { tick } from 'svelte';
 
 	type Props = {
-		existingCommitId?: string;
 		projectId: string;
 		stackId?: string;
 		actionLabel: string;
@@ -29,7 +28,6 @@
 	};
 
 	const {
-		existingCommitId,
 		projectId,
 		stackId,
 		actionLabel,
@@ -142,14 +140,6 @@
 	}
 </script>
 
-<CommitSuggestionsPlugin
-	bind:this={commitSuggestionsPlugin}
-	{projectId}
-	{canUseAI}
-	{suggestionsHandler}
-	{existingCommitId}
-/>
-
 <div class="commit-message-wrap">
 	<MessageEditorInput
 		testId={TestId.CommitDrawerTitleInput}

apps/desktop/src/components/v3/CommitView.svelte

@@ -152,7 +152,6 @@
 					initialTitle={splitMessage(commit.message).title}
 					initialMessage={splitMessage(commit.message).description}
 					loading={messageUpdateResult.current.isLoading}
-					existingCommitId={commit.id}
 				/>
 			</Drawer>
 		{:else}

apps/desktop/src/components/v3/FileContextMenu.svelte

@@ -24,7 +24,6 @@
 	type Props = {
 		isUncommitted: boolean;
 		trigger?: HTMLElement;
-		isBinary?: boolean;
 		unSelectChanges: (changes: TreeChange[]) => void;
 	};
 
@@ -42,7 +41,7 @@
 		);
 	}
 
-	const { trigger, isBinary = false, unSelectChanges, isUncommitted }: Props = $props();
+	const { trigger, unSelectChanges, isUncommitted }: Props = $props();
 	const [stackService, project] = inject(StackService, Project);
 	const userSettings = getContextStoreBySymbol<Settings, Writable<Settings>>(SETTINGS);
 
@@ -110,7 +109,7 @@
 			<ContextMenuSection>
 				{#if item.changes.length > 0}
 					{@const changes = item.changes}
-					{#if !isBinary && isUncommitted}
+					{#if isUncommitted}
 						<ContextMenuItem
 							label="Discard changes"
 							onclick={() => {

apps/desktop/src/components/v3/FileListItemWrapper.svelte

@@ -4,7 +4,6 @@
 	import { draggableChips } from '$lib/dragging/draggable';
 	import { ChangeDropData } from '$lib/dragging/draggables';
 	import { getFilename } from '$lib/files/utils';
-	import { DiffService } from '$lib/hunks/diffService.svelte';
 	import { ChangeSelectionService } from '$lib/selection/changeSelection.svelte';
 	import { IdSelection } from '$lib/selection/idSelection.svelte';
 	import { key, type SelectionId } from '$lib/selection/key';
@@ -56,17 +55,13 @@
 
 	const idSelection = getContext(IdSelection);
 	const changeSelection = getContext(ChangeSelectionService);
-	const diffService = getContext(DiffService);
 
 	let contextMenu = $state<ReturnType<typeof FileContextMenu>>();
 	let draggableEl: HTMLDivElement | undefined = $state();
 
 	const selection = $derived(changeSelection.getById(change.path));
 	const indeterminate = $derived(selection.current && selection.current.type === 'partial');
 	const selectedChanges = $derived(idSelection.treeChanges(projectId, selectionId));
-	const diffResult = $derived(diffService.getDiff(projectId, change));
-
-	const isBinary = $derived(diffResult.current.data?.type === 'Binary');
 	const isUncommitted = $derived(selectionId?.type === 'worktree');
 
 	const previousTooltipText = $derived(
@@ -138,7 +133,6 @@
 		bind:this={contextMenu}
 		trigger={draggableEl}
 		{isUncommitted}
-		{isBinary}
 		{unSelectChanges}
 	/>