Skip to content

improvement for readCSV file and code refactoring #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improvement for readCSV file and code refactoring #53

wants to merge 1 commit into from

Conversation

Virous77
Copy link

  1. Used fs/promises for promise-based file operations.
  2. Improved the construction of the beginSQLInsert statement.
  3. Extracted the validation logic into a separate function (validateRow).
  4. Refactored file existence check into a separate function.
  5. Added .nvmrc file

@servesh-chaturvedi
Copy link

Hey could you modify your vscode settings so that no unnecessary settings like single quotes to double or tab spaces appear? That ways, it is helpful to check exact changes🙂

@Virous77
Copy link
Author

Hey could you modify your vscode settings so that no unnecessary settings like single quotes to double or tab spaces appear? That ways, it is helpful to check exact changes🙂

sure will look into that:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jsvigneshkanna jsvigneshkanna jsvigneshkanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Virous77 @servesh-chaturvedi @jsvigneshkanna