Skip to content

Commit 7c9c992

Browse files
committed
JS: Make isAssignedInUniqueFile global, as it should be
1 parent 84e7101 commit 7c9c992

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ module AccessPath {
206206
* Holds if the global `accessPath` is only assigned to from one file, not counting
207207
* self-assignments.
208208
*/
209+
overlay[global]
209210
predicate isAssignedInUniqueFile(string accessPath) {
210211
strictcount(File f | isAssignedInFile(accessPath, f)) = 1
211212
}
@@ -511,7 +512,7 @@ module AccessPath {
511512
/**
512513
* Holds if there is a step from `pred` to `succ` through an assignment to an access path.
513514
*/
514-
overlay[caller]
515+
overlay[caller?]
515516
pragma[inline]
516517
predicate step(DataFlow::Node pred, DataFlow::Node succ) {
517518
exists(string name, Root root |

0 commit comments

Comments
 (0)