Skip to content

Commit 92bb4b3

Browse files
committed
JS: Address some comments from hvitved
1 parent 4568967 commit 92bb4b3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1052,7 +1052,7 @@ predicate simpleLocalFlowStep(Node node1, Node node2) {
10521052
exists(Function f |
10531053
// When the first parameter is a rest parameter, flow into the rest parameter as a local flow step
10541054
// to ensure we preserve knowledge about array indices
1055-
(node1 = TStaticParameterArrayNode(f) or node1 = TDynamicParameterArrayNode(f))
1055+
node1 = TStaticParameterArrayNode(f) or node1 = TDynamicParameterArrayNode(f)
10561056
|
10571057
// rest parameter at initial position
10581058
exists(Parameter rest |
@@ -1163,7 +1163,7 @@ predicate readStep(Node node1, ContentSet c, Node node2) {
11631163
c = ContentSet::arrayElementUnknown()
11641164
)
11651165
or
1166-
// Prepare to store spread arguments into the dynamic arguments array, when it isn't the initial spread argument
1166+
// Prepare to store spread arguments into the dynamic arguments array, when it isn't the initial argument
11671167
exists(InvokeExpr invoke, int n, Expr argument, Content storeContent |
11681168
invoke.getArgument(n).stripParens().(SpreadElement).getOperand() = argument and
11691169
n > 0 and // n=0 is handled as a value step

0 commit comments

Comments
 (0)