Fix diff-informed predicates

Author: owen-mc

go/ql/lib/semmle/go/frameworks/CryptoLibraries.qll

@@ -21,8 +21,6 @@ private module HashConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof HashAlgorithmInit }
 
   predicate isSink(DataFlow::Node sink) { any() }
-
-  predicate observeDiffInformedIncrementalMode() { any() }
 }
 
 /** Tracks the flow of hash algorithms. */
@@ -50,8 +48,6 @@ private module EncryptionConfig implements DataFlow::ConfigSig {
   predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
     any(BlockModeInit nbcm).step(node1, node2)
   }
-
-  predicate observeDiffInformedIncrementalMode() { any() }
 }
 
 /**

go/ql/src/Security/CWE-327/WeakSensitiveDataHashing.ql

@@ -39,6 +39,8 @@ module NormalHashFunctionFlow {
       // make sinks barriers so that we only report the closest instance
       isSink(node)
     }
+
+    predicate observeDiffInformedIncrementalMode() { any() }
   }
 
   import TaintTracking::Global<Config>
@@ -70,6 +72,8 @@ module ComputationallyExpensiveHashFunctionFlow {
       // make sinks barriers so that we only report the closest instance
       isSink(node)
     }
+
+    predicate observeDiffInformedIncrementalMode() { any() }
   }
 
   import TaintTracking::Global<Config>