C#: HardcodedConnectionString

d10c · d10c · commit f65f86370338 · 2025-07-04T11:48:14.000+02:00
diff --git a/csharp/ql/src/Security Features/CWE-798/HardcodedConnectionString.ql b/csharp/ql/src/Security Features/CWE-798/HardcodedConnectionString.ql
@@ -39,8 +39,10 @@ module ConnectionStringConfig implements DataFlow::ConfigSig {
 
   predicate isBarrier(DataFlow::Node node) { node instanceof StringFormatSanitizer }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 does not select a source or sink originating from the flow call on line 49 (/Users/d10c/src/semmle-code/ql/csharp/ql/src/Security Features/CWE-798/HardcodedConnectionString.ql@52:3:52:73)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSinkLocation(DataFlow::Node sink) {
+    any(Call call | call.getAnArgument() = sink.asExpr()).getLocation() = result
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,10 @@ module ConnectionStringConfig implements DataFlow::ConfigSig {`
`39`	`39`
`40`	`40`	`predicate isBarrier(DataFlow::Node node) { node instanceof StringFormatSanitizer }`
`41`	`41`
`42`		`- predicate observeDiffInformedIncrementalMode() {`
`43`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 does not select a source or sink originating from the flow call on line 49 (/Users/d10c/src/semmle-code/ql/csharp/ql/src/Security Features/CWE-798/HardcodedConnectionString.ql@52:3:52:73)`
	`42`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`43`	`+`
	`44`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) {`
	`45`	`+ any(Call call \| call.getAnArgument() = sink.asExpr()).getLocation() = result`
`44`	`46`	`}`
`45`	`47`	`}`
`46`	`48`