Skip to content

Commit fffaa56

Browse files
committed
Fix java/local-temp-file-or-directory-information-disclosure regression
1 parent 2e8952c commit fffaa56

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

java/ql/lib/semmle/code/java/security/TempDirLocalInformationDisclosureQuery.qll

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ module TempDirSystemGetPropertyDirectlyToMkdir =
203203
/**
204204
* A `MethodCall` against a method that creates a temporary file or directory in a shared temporary directory.
205205
*/
206+
overlay[local?]
206207
abstract class MethodCallInsecureFileCreation extends MethodCall {
207208
/**
208209
* Gets the type of entity created (e.g. `file`, `directory`, ...).
@@ -218,6 +219,7 @@ abstract class MethodCallInsecureFileCreation extends MethodCall {
218219
/**
219220
* An insecure call to `java.io.File.createTempFile`.
220221
*/
222+
overlay[local?]
221223
class MethodCallInsecureFileCreateTempFile extends MethodCallInsecureFileCreation {
222224
MethodCallInsecureFileCreateTempFile() {
223225
this.getMethod() instanceof MethodFileCreateTempFile and
@@ -246,6 +248,7 @@ class MethodGuavaFilesCreateTempFile extends Method {
246248
/**
247249
* A call to the `com.google.common.io.Files.createTempDir` method.
248250
*/
251+
overlay[local?]
249252
class MethodCallInsecureGuavaFilesCreateTempFile extends MethodCallInsecureFileCreation {
250253
MethodCallInsecureGuavaFilesCreateTempFile() {
251254
this.getMethod() instanceof MethodGuavaFilesCreateTempFile

0 commit comments

Comments
 (0)