fix: When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he cmdbar_bg configuration color does not fully take effect
cruessler
approved these changes
Oct 28, 2025
Collaborator
cruessler
left a comment
cruessler
left a comment
There was a problem hiding this comment.
LGTM! I’ve tested it locally and it works regardless of whether I’ve customized cmdbar_bg.
Collaborator
|
@wugeer Would you mind resolving the conflict in |
cruessler
pushed a commit
to cruessler/gitui
that referenced
this pull request
Oct 29, 2025
…he cmdbar_bg configuration color does not fully take effect (gitui-org#2348) Co-authored-by: extrawurst <[email protected]>
Contributor
Author
Sorry for the late reply. I just saw this message. I'm glad the issue is resolved without bothering you. Thx! @cruessler @extrawurst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2347.
It changes the following:
linefield from theCommandstruct, along with its corresponding initializationcmdbar_extra_lines_bgfield from theThemestruct, along with its corresponding initializationI followed the checklist:
make checkwithout errors