Fix memleak in syncargs errstr #4638
Open
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 28, 2025 15:00
args->errstr is generated by gf_strdup, so it should be manually freed at the end of its life cycle. Fixes: gluster#4637 Signed-off-by: chenjinhao <[email protected]>
Add missing gd_syncargs_fini() calls in functions to avoid mutex and syncbarrier leaks. original patch: 6279c5b Updates: gluster#1000 Signed-off-by: chenjinhao <[email protected]>
Fix following compilation error
ec-inode-read.c: In function 'ec_manager_readv':
ec-inode-read.c:1375:13: error: a label can only be part of a statement and a declaration is not a statement
uintptr_t inode_read_mask = ec_inode_readmask_get(fop->fd->inode,
^~~~~~~~~
make[5]: *** [Makefile:650: ec-inode-read.lo] Error 1
Fixes: gluster#4637
Signed-off-by: chenjinhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory allocated for
args->errstrviagf_strdupmust be explicitly freed before the function returns or at the appropriate cleanup point.