Skip to content

Commit 66707bc

Browse files
authored
Fix actions lint (#36029)
actionlint since https://github.com/rhysd/actionlint/releases/tag/v1.7.9 detects constant conditions and this workflow was being disabled in 58d2a87 by such a condition which made the lint fail: https://github.com/go-gitea/gitea/actions/runs/19673752806/job/56349128912?pr=36028 Instead, remove the whole workflow file. I'm sure we can re-create it if the need arises. Also, I locked the actionlint dependency to prevent similar surprises in the future.
1 parent 000c06d commit 66707bc

File tree

3 files changed

+4
-45
lines changed

3 files changed

+4
-45
lines changed

.github/workflows/pull-e2e-tests.yml

Lines changed: 0 additions & 35 deletions
This file was deleted.

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ SWAGGER_PACKAGE ?= github.com/go-swagger/go-swagger/cmd/[email protected]
3939
XGO_PACKAGE ?= src.techknowlogick.com/xgo@latest
4040
GO_LICENSES_PACKAGE ?= github.com/google/go-licenses@v1
4141
GOVULNCHECK_PACKAGE ?= golang.org/x/vuln/cmd/govulncheck@v1
42-
ACTIONLINT_PACKAGE ?= github.com/rhysd/actionlint/cmd/actionlint@v1
42+
ACTIONLINT_PACKAGE ?= github.com/rhysd/actionlint/cmd/actionlint@v1.7.9
4343
GOPLS_PACKAGE ?= golang.org/x/tools/[email protected]
4444

4545
DOCKER_IMAGE ?= gitea/gitea

tests/e2e/README.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,7 @@ make clean frontend
1717

1818
## Install playwright system dependencies
1919
```
20-
npx playwright install-deps
21-
```
22-
23-
24-
## Run all tests via local act_runner
25-
```
26-
act_runner exec -W ./.github/workflows/pull-e2e-tests.yml --event=pull_request --default-actions-url="https://github.com" -i catthehacker/ubuntu:runner-latest
20+
pnpm exec playwright install-deps
2721
```
2822

2923
## Run sqlite e2e tests
@@ -85,8 +79,8 @@ TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TES
8579

8680
Although the main goal of e2e is assertion testing, we have added a framework for visual regress testing. If you are working on front-end features, please use the following:
8781
- Check out `main`, `make clean frontend`, and run e2e tests with `VISUAL_TEST=1` to generate outputs. This will initially fail, as no screenshots exist. You can run the e2e tests again to assert it passes.
88-
- Check out your branch, `make clean frontend`, and run e2e tests with `VISUAL_TEST=1`. You should be able to assert you front-end changes don't break any other tests unintentionally.
82+
- Check out your branch, `make clean frontend`, and run e2e tests with `VISUAL_TEST=1`. You should be able to assert you front-end changes don't break any other tests unintentionally.
8983

90-
VISUAL_TEST=1 will create screenshots in tests/e2e/test-snapshots. The test will fail the first time this is enabled (until we get visual test image persistence figured out), because it will be testing against an empty screenshot folder.
84+
VISUAL_TEST=1 will create screenshots in tests/e2e/test-snapshots. The test will fail the first time this is enabled (until we get visual test image persistence figured out), because it will be testing against an empty screenshot folder.
9185

9286
ACCEPT_VISUAL=1 will overwrite the snapshot images with new images.

0 commit comments

Comments
 (0)