Skip to content

Commit 695496c

Browse files
committed
Apply Go modernization fixes - use strings.CutPrefix instead of HasPrefix+TrimPrefix
1 parent 722ac05 commit 695496c

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

routers/api/v1/shared/action.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,32 +186,32 @@ func ListRuns(ctx *context.APIContext, ownerID, repoID int64) {
186186
opts.CreatedBefore = endDate
187187
}
188188
}
189-
} else if strings.HasPrefix(created, ">=") {
189+
} else if after, ok := strings.CutPrefix(created, ">="); ok {
190190
// Greater than or equal format: ">=2023-01-01"
191-
dateStr := strings.TrimPrefix(created, ">=")
191+
dateStr := after
192192
startDate, err := time.Parse("2006-01-02", dateStr)
193193
if err == nil {
194194
opts.CreatedAfter = startDate
195195
}
196-
} else if strings.HasPrefix(created, ">") {
196+
} else if after, ok := strings.CutPrefix(created, ">"); ok {
197197
// Greater than format: ">2023-01-01"
198-
dateStr := strings.TrimPrefix(created, ">")
198+
dateStr := after
199199
startDate, err := time.Parse("2006-01-02", dateStr)
200200
if err == nil {
201201
opts.CreatedAfter = startDate.Add(24 * time.Hour)
202202
}
203-
} else if strings.HasPrefix(created, "<=") {
203+
} else if after, ok := strings.CutPrefix(created, "<="); ok {
204204
// Less than or equal format: "<=2023-12-31"
205-
dateStr := strings.TrimPrefix(created, "<=")
205+
dateStr := after
206206
endDate, err := time.Parse("2006-01-02", dateStr)
207207
if err == nil {
208208
// Set to end of day
209209
endDate = endDate.Add(24*time.Hour - time.Second)
210210
opts.CreatedBefore = endDate
211211
}
212-
} else if strings.HasPrefix(created, "<") {
212+
} else if after, ok := strings.CutPrefix(created, "<"); ok {
213213
// Less than format: "<2023-12-31"
214-
dateStr := strings.TrimPrefix(created, "<")
214+
dateStr := after
215215
endDate, err := time.Parse("2006-01-02", dateStr)
216216
if err == nil {
217217
opts.CreatedBefore = endDate

0 commit comments

Comments
 (0)