AGit: branch protection rules not applied to AGit after update

[AdamMajer]

Description

NOTE: demo.gitea.com is inaccessible for a while, so can't reproduce it there.

Attached screenshots. Basically, when branch protection rules exist to dismiss stale reviews automatically, the review request is not re-requested after dismissal leaving a review without review requests after a change.

Gitea Version

1.24.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Branch protection rules in a regular PR

Branch protection rules with AGit

Git Version

No response

Operating System

No response

How are you running Gitea?

self-hosted

Database

PostgreSQL

[a1012112796]

In my view, the second logic is the right one, because the review request should be valid only once. After the review was submitted, it should not be automatically resubmitted anyway.

[AdamMajer]

review is not resubmitted. The review should be re-requested.

These reviews are governed by the branch protection rules. If a PR requires a review by some, it's requested. When the PR is updated, then the old review is marked as stale. branch protection rules then kick in and should re-request that review after it's dismissed.

In either case, it's inconsistent behaviour between the two implementations. Maybe we need another checkbox to re-request stale reviews in addition to dismissing them, if both actions are valid here. After all, stale reviews don't need to be dismissed to be re-requested in the UI.