-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add more prometheus metrics #33307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add more prometheus metrics #33307
Conversation
cc06fe3
to
28615e2
Compare
46424ca
to
2f86823
Compare
2f86823
to
056a308
Compare
still kind of buggy as it doesn't properly encode commands
to be reintroduced later, for now it would require figuring out which arg is the actual command
List of added metrics (and notes): migrations
cachethere's no standard here so cache stays in gitea namespace until one emerges
httpWell defined so standard is applied with few deviations.
dbper spec
gitmight be useful to find if there are some very long running commands and look for them or if a lot of them are processing at the same time. I'd like to add a label which command it was as
cron
Suggestions for more or comments are welcome. I'll update this comment as things go. |
for completeness from the linked issue:
sidenote relating to #32866 While this tries to follow otel semconv (deviating for buckets and units) migrating to otel with prometheus exporter is not on my roadmap as of now due to performance difference between the two. |
I feel like this is now in a state where I wouldn't want it merged as is but some feedback/test deployment to finetune buckets or figure out if metrics are useful or not would be good so I'm taking the draft label down. |
Adds http tracking metrics, cache latency histogram, hit/miss counter for cache, counter and histogram for git commands and counters for migration success/fail and currently running ones.
gitea_issues_open
andgitea_issues_closed
are deprecated for labels ongitea_issues
Closes: #14724