Skip to content

Replace lint-go-gopls with additional govet linters #36028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2025
Merged

Replace lint-go-gopls with additional govet linters #36028

merged 3 commits into from
Nov 29, 2025
+5 −31

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 25, 2025 •
edited
Loading

Many (but not all) analyzers ran by gopls check are available in golangci-lint as part of default-disabled govet linters, so I think it's best we remove this manual linting step and let golangci-lint handle it. I hand-picked two available linters that were previously linted using gopls and this list is not exhaustive.

This will reduce CI time by about 3 minutes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2025
@silverwind
Copy link
Member Author

silverwind commented Nov 26, 2025 •
edited
Loading

For reference, here are all the potential analyzers that could be enabled later. All of these are in gopls check, but not all of them are in go vet:

https://github.com/golang/tools/blob/d32ec344545c517da66ce368d0298ed9655d27ac/gopls/internal/settings/analysis.go#L204-L250

@silverwind
Merge remote-tracking branch 'origin/main' into rmgopls
4271dc7 
* origin/main:
  Fix actions lint (go-gitea#36029)
  Fix oauth2 session gob register (go-gitea#36017)
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2025
@silverwind silverwind enabled auto-merge (squash) November 29, 2025 13:43
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 29, 2025
@silverwind silverwind merged commit b54af88 into go-gitea:main Nov 29, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 29, 2025
@silverwind silverwind deleted the rmgopls branch November 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@TheFox0x7 TheFox0x7 TheFox0x7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. topic/code-linting

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@silverwind @lunny @TheFox0x7 @GiteaBot