refactor: change returned status code and description in clickhouse error handling (#286)

Author: AleksandrMatsko

cmd/e2e-test/carbon-clickhouse.go

@@ -28,7 +28,7 @@ type CarbonClickhouse struct {
 
 func (c *CarbonClickhouse) Start(testDir, clickhouseURL string) (string, error) {
 	if len(c.Version) == 0 {
-		c.Version = "0.11.4"
+		c.Version = "latest"
 	}
 	if len(c.DockerImage) == 0 {
 		c.DockerImage = "ghcr.io/go-graphite/carbon-clickhouse"

helper/clickhouse/clickhouse.go

@@ -72,7 +72,10 @@ func extractClickhouseError(e string) (int, string) {
 			return http.StatusServiceUnavailable, "Storage configuration error"
 		}
 	}
-	return http.StatusInternalServerError, "Storage error"
+	if strings.HasPrefix(e, "clickhouse response status 404: Code: 60. DB::Exception: Table default.") {
+		return http.StatusServiceUnavailable, "Storage default tables damaged"
+	}
+	return http.StatusServiceUnavailable, "Storage unavailable"
 }
 
 func HandleError(w http.ResponseWriter, err error) (status int, queueFail bool) {

helper/clickhouse/clickhouse_test.go

@@ -34,10 +34,15 @@ func Test_extractClickhouseError(t *testing.T) {
 			wantStatus:  http.StatusForbidden,
 			wantMessage: "Storage read limit for memory",
 		},
+		{
+			errStr:      "clickhouse response status 404: Code: 60. DB::Exception: Table default.graphite_index does not exist. (UNKNOWN_TABLE) (version 23.12.6.19 (official build))\n",
+			wantStatus:  http.StatusServiceUnavailable,
+			wantMessage: "Storage default tables damaged",
+		},
 		{
 			errStr:      "Other error",
-			wantStatus:  http.StatusInternalServerError,
-			wantMessage: "Storage error",
+			wantStatus:  http.StatusServiceUnavailable,
+			wantMessage: "Storage unavailable",
 		},
 	}
 	for _, tt := range tests {