Make most container template copy constructors explicit

Author: aaronfranke

core/config/project_settings.cpp

@@ -1514,9 +1514,9 @@ void ProjectSettings::_bind_methods() {
 
 void ProjectSettings::_add_builtin_input_map() {
 	if (InputMap::get_singleton()) {
-		HashMap<String, List<Ref<InputEvent>>> builtins = InputMap::get_singleton()->get_builtins();
+		const HashMap<String, List<Ref<InputEvent>>> builtins = HashMap<String, List<Ref<InputEvent>>>(InputMap::get_singleton()->get_builtins());
 
-		for (KeyValue<String, List<Ref<InputEvent>>> &E : builtins) {
+		for (const KeyValue<String, List<Ref<InputEvent>>> &E : builtins) {
 			Array events;
 
 			// Convert list of input events into array

core/config/project_settings.h

@@ -200,7 +200,7 @@ class ProjectSettings : public Object {
 	const HashMap<StringName, PropertyInfo> &get_custom_property_info() const;
 	uint64_t get_last_saved_time() { return last_save_time; }
 
-	List<String> get_input_presets() const { return input_presets; }
+	List<String> get_input_presets() const { return List<String>(input_presets); }
 
 	Variant get_setting_with_override(const StringName &p_name) const;
 	Variant get_setting_with_override_and_custom_features(const StringName &p_name, const Vector<String> &p_features) const;

core/extension/gdextension.cpp

@@ -952,7 +952,7 @@ void GDExtension::prepare_reload() {
 				state.push_back(Pair<String, Variant>(P.name, value));
 			}
 			E.value.instance_state[obj_id] = {
-				state, // List<Pair<String, Variant>> properties;
+				List<Pair<String, Variant>>(state), // List<Pair<String, Variant>> properties;
 				obj->is_extension_placeholder(), // bool is_placeholder;
 			};
 		}

core/input/input_map.cpp

@@ -874,7 +874,7 @@ const HashMap<String, List<Ref<InputEvent>>> &InputMap::get_builtins_with_featur
 }
 
 void InputMap::load_default() {
-	HashMap<String, List<Ref<InputEvent>>> builtins = get_builtins_with_feature_overrides_applied();
+	const HashMap<String, List<Ref<InputEvent>>> builtins = HashMap<String, List<Ref<InputEvent>>>(get_builtins_with_feature_overrides_applied());
 
 	for (const KeyValue<String, List<Ref<InputEvent>>> &E : builtins) {
 		String name = E.key;

core/io/file_access_pack.cpp

@@ -140,7 +140,7 @@ uint8_t *PackedData::get_file_hash(const String &p_path) {
 HashSet<String> PackedData::get_file_paths() const {
 	HashSet<String> file_paths;
 	_get_file_paths(root, root->name, file_paths);
-	return file_paths;
+	return HashSet<String>(file_paths);
 }
 
 void PackedData::_get_file_paths(PackedDir *p_dir, const String &p_parent_dir, HashSet<String> &r_paths) const {

core/io/ip.cpp

@@ -205,7 +205,7 @@ IPAddress IP::get_resolve_item_address(ResolverID p_id) const {
 		return IPAddress();
 	}
 
-	List<IPAddress> res = resolver->queue[p_id].response;
+	const List<IPAddress> res = List<IPAddress>(resolver->queue[p_id].response);
 
 	for (const IPAddress &E : res) {
 		if (E.is_valid()) {
@@ -224,7 +224,7 @@ Array IP::get_resolve_item_addresses(ResolverID p_id) const {
 		return Array();
 	}
 
-	List<IPAddress> res = resolver->queue[p_id].response;
+	const List<IPAddress> res = List<IPAddress>(resolver->queue[p_id].response);
 
 	Array result;
 	for (const IPAddress &E : res) {

core/math/a_star_grid_2d.cpp

@@ -158,7 +158,7 @@ void AStarGrid2D::update() {
 			solid_mask.push_back(false);
 		}
 		solid_mask.push_back(true);
-		points.push_back(line);
+		points.push_back(LocalVector<Point>(line));
 	}
 
 	for (int32_t x = region.position.x; x < end_x + 2; x++) {

core/math/geometry_3d.h

@@ -491,7 +491,7 @@ class Geometry3D {
 		};
 
 		if (polygon.is_empty()) {
-			return polygon;
+			return Vector<Vector3>(polygon);
 		}
 
 		int *location_cache = (int *)alloca(sizeof(int) * polygon.size());
@@ -514,7 +514,7 @@ class Geometry3D {
 		}
 
 		if (outside_count == 0) {
-			return polygon; // No changes.
+			return Vector<Vector3>(polygon); // No changes.
 		} else if (inside_count == 0) {
 			return Vector<Vector3>(); // Empty.
 		}

core/object/class_db.cpp

@@ -1004,7 +1004,7 @@ void ClassDB::get_method_list_with_compatibility(const StringName &p_class, List
 #endif // DEBUG_ENABLED
 
 		for (const KeyValue<StringName, LocalVector<MethodBind *, unsigned int, false, false>> &E : type->method_map_compatibility) {
-			LocalVector<MethodBind *> compat = E.value;
+			const LocalVector<MethodBind *> compat = LocalVector<MethodBind *>(E.value);
 			for (MethodBind *method : compat) {
 				MethodInfo minfo = info_from_bind(method);
 

core/os/os.cpp

@@ -640,7 +640,7 @@ bool OS::is_restart_on_exit_set() const {
 }
 
 List<String> OS::get_restart_on_exit_arguments() const {
-	return restart_commandline;
+	return List<String>(restart_commandline);
 }
 
 PackedStringArray OS::get_connected_midi_inputs() {