Editor crashes while CSV translation is open in LibreOffice Calc

[jansenMurphy]

Tested versions

• Reproducible in Godot_v4.4-stable_mono_win64
• Not Reproducible in Godot_v4.3-stable_win64
• Godot_v4.3-stable_mono_win64 is unable to re-import the file, but does not crash

System information

Godot v4.4.stable.mono - Windows 11 (build 22631) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 32.0.15.6094) - AMD Ryzen 9 5900X 12-Core Processor (24 threads)

Issue description

Editor crashes after double-clicking a not-found resource asset while that asset is open in another program like LibreOffice Calc.

The nasty-looking error messages are unfortunate, but not the ultimate problem I'm talking about

Steps to reproduce

Steps assume that you have LibreOffice installed on your system. This bug may apply to other programs like Microsoft Excel, but I don't have access to Excel.

• Create a csv through some external program and save it to a godot project folder
  • An appropriately formatted csv for english translations has "key" and "en" headers and at least one row with values for each of those columns.
• Close LibreOffice Calc
• Open the godot project and make sure that the translation csv is imported correctly
• Open that csv in LibreOffice Calc, edit it, and save it. Keep LibreOffice Calc open
• Go back to the Godot project and observe that the csv has failed to import correctly
• Double click on the asset to try to open it
• Observe editor crash

Minimal reproduction project (MRP)

editor_crash_from_csv.zip

Crashdump.zip

[jansenMurphy]

Thanks for all the hard work y'all've put into the engine!

[Calinou]

I can't reproduce this on 4.5.dev 7b9c512 (Linux). I don't get any import errors or crashes using LibreOffice Calc 24.8.6.2.

[matheusmdx]

Tested on latest master 215acd5 and i can confirm the crash. The crash comes from a read access violation in editor\plugins\editor_resource_tooltip_plugins.cpp:75 as FileAcecss::open fails to open the csv file and engine tries to use the null reference.

Backtrace

EditorResourceTooltipPlugin::make_default_tooltip(const String & p_resource_path) Line 75 (c:\Users\Matheus\Downloads\Godot Source\editor\plugins\editor_resource_tooltip_plugins.cpp:75)
FileSystemDock::create_tooltip_for_path(const String & p_path) Line 2793 (c:\Users\Matheus\Downloads\Godot Source\editor\filesystem_dock.cpp:2793)
FileSystemTree::make_custom_tooltip(const String & p_text) Line 73 (c:\Users\Matheus\Downloads\Godot Source\editor\filesystem_dock.cpp:73)
Viewport::_gui_show_tooltip_at(const Vector2i & p_pos) Line 1554 (c:\Users\Matheus\Downloads\Godot Source\scene\main\viewport.cpp:1554)
Viewport::_gui_show_tooltip() Line 1537 (c:\Users\Matheus\Downloads\Godot Source\scene\main\viewport.cpp:1537)
call_with_variant_args_helper<Viewport>(Viewport * p_instance, void(Viewport::*)() p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<> __formal) Line 228 (c:\Users\Matheus\Downloads\Godot Source\core\variant\binder_common.h:228)
call_with_variant_args<Viewport>(Viewport * p_instance, void(Viewport::*)() p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error) Line 338 (c:\Users\Matheus\Downloads\Godot Source\core\variant\binder_common.h:338)
CallableCustomMethodPointer<Viewport,void>::call(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 107 (c:\Users\Matheus\Downloads\Godot Source\core\object\callable_method_pointer.h:107)
Callable::callp(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 58 (c:\Users\Matheus\Downloads\Godot Source\core\variant\callable.cpp:58)
Object::emit_signalp(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 1252 (c:\Users\Matheus\Downloads\Godot Source\core\object\object.cpp:1252)
Object::emit_signal<>(const StringName & p_name) Line 923 (c:\Users\Matheus\Downloads\Godot Source\core\object\object.h:923)
SceneTree::process_timers(double p_delta, bool p_physics_frame) Line 783 (c:\Users\Matheus\Downloads\Godot Source\scene\main\scene_tree.cpp:783)
SceneTree::process(double p_time) Line 702 (c:\Users\Matheus\Downloads\Godot Source\scene\main\scene_tree.cpp:702)
Main::iteration() Line 4736 (c:\Users\Matheus\Downloads\Godot Source\main\main.cpp:4736)
OS_Windows::run() Line 2268 (c:\Users\Matheus\Downloads\Godot Source\platform\windows\os_windows.cpp:2268)
widechar_main(int argc, wchar_t * * argv) Line 97 (c:\Users\Matheus\Downloads\Godot Source\platform\windows\godot_windows.cpp:97)
_main() Line 122 (c:\Users\Matheus\Downloads\Godot Source\platform\windows\godot_windows.cpp:122)
main(int argc, char * * argv) Line 136 (c:\Users\Matheus\Downloads\Godot Source\platform\windows\godot_windows.cpp:136)
WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 150 (c:\Users\Matheus\Downloads\Godot Source\platform\windows\godot_windows.cpp:150)
[Inline Frame] invoke_main() Line 102 (d:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102)
__scrt_common_main_seh() Line 288 (d:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
kernel32.dll!00007ff86bff7374() (Unknown Source:0)
ntdll.dll!00007ff86c89cc91() (Unknown Source:0)

Interesting that using FileAccess.open and FileAccess.get_size in GDScript works without issues.

The "regression" started between 4.4 dev1 and 4.4 dev 2 by pr #93064 but seems that was somehow broken before as in 4.4 dev 1 throws an error saying the file didn't exist: editor/filesystem_dock.cpp:2725 - Condition "!FileAccess::exists(p_path)" is true. Returning: nullptr. The relevant difference was this:

https://github.com/godotengine/godot/pull/93064/files#diff-d1a420b01f63a620201ea4099997331bc4320c30b0b5371e1a16801b2a32965aL61-L67

Before the engine used FileAccess::open to check if file exists (and that fails to open the csv file in use), FileAccess::exists wrongly fails and makes the engine return early in FileSystemDock::create_tooltip_for_path with the mentioned error.

The solution would be either makes FileAccess::open works as the file can be used normally by FileAccess.open in GDScript or handle the null reference in editor\plugins\editor_resource_tooltip_plugins.cpp:75.