refactor(models.Execution): add none as a type option for started a…
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd `finished` fields These were previously only typed as `datetime`. This caught me out, as I got a runtime error where they were None. Adding the type hint should hopefully help others avoiding the same mistake.
mhusbynflow
force-pushed
the
add-execution-types
branch
from
136c898 to
e48f354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd
finishedfieldsThese were previously only typed as
datetime. This caught me out, as I got a runtime error where they were None. Adding the type hint should hopefully help others avoiding the same mistake.