Skip to content

Commit 8270736

Browse files
committed
feature: Improvements - replace gcp with cloud_run and minor correction in Readme file
1 parent cbe25e1 commit 8270736

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ coordinator = LlmAgent(
119119

120120
### 🚀 Deployment Options
121121

122-
Running the Agent Locally with Docker Container:
122+
Deploying the Agent Locally with Docker Container:
123123

124124
```bash
125125
adk deploy docker <agent-folder> --with_ui
126126
```
127127

128-
Running the Agent in Google Cloud (GCP)
128+
Deploying the Agent in Google Cloud (Cloud Run)
129129

130130
```bash
131131
adk deploy cloud_run <agent-folder> --with_ui

src/google/adk/cli/cli_tools_click.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ def cli_deploy_to_cloud_run(
777777
try:
778778
cli_deploy.run(
779779
agent_folder=agent,
780-
provider="gcp",
780+
provider="cloud_run",
781781
project=project,
782782
region=region,
783783
service_name=service_name,

src/google/adk/cli/deployers/gcp_deployer.py renamed to src/google/adk/cli/deployers/cloud_run_deployer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# deployers/gcp_deployer.py
1+
# deployers/cloud_run_deployer.py
22

33
import subprocess
44
import os
@@ -7,7 +7,7 @@
77
from ..deployers.base_deployer import Deployer
88

99

10-
class GCPDeployer(Deployer):
10+
class CloudRunDeployer(Deployer):
1111

1212
def deploy(
1313
self,

src/google/adk/cli/deployers/deployer_factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from ..deployers.gcp_deployer import GCPDeployer
1+
from ..deployers.cloud_run_deployer import CloudRunDeployer
22
from ..deployers.docker_deployer import DockerDeployer
33
# Future deployers can be added here
44

@@ -10,7 +10,7 @@ def get_deployer(cloud_provider: str):
1010
"""Returns the appropriate deployer based on the cloud provider."""
1111
deployers = {
1212
'docker': DockerDeployer(),
13-
'gcp': GCPDeployer(),
13+
'cloud_run': CloudRunDeployer(),
1414
# Future providers: 'aws': AWSDeployer(), 'k8s': KubernetesDeployer()
1515
}
1616

tests/unittests/cli/utils/test_cli_deploy.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ def _factory(include_requirements: bool) -> Path:
7272
# _resolve_project
7373
def test_resolve_project_with_option() -> None:
7474
"""It should return the explicit project value untouched."""
75-
gcpDeployer = DeployerFactory.get_deployer("gcp")
76-
assert gcpDeployer._resolve_project("my-project") == "my-project"
75+
cloudRunDeployer = DeployerFactory.get_deployer("cloud_run")
76+
assert cloudRunDeployer._resolve_project("my-project") == "my-project"
7777

7878

7979
def test_resolve_project_from_gcloud(monkeypatch: pytest.MonkeyPatch) -> None:
@@ -85,20 +85,20 @@ def test_resolve_project_from_gcloud(monkeypatch: pytest.MonkeyPatch) -> None:
8585
)
8686

8787
with mock.patch("click.echo") as mocked_echo:
88-
gcpDeployer = DeployerFactory.get_deployer("gcp")
89-
assert gcpDeployer._resolve_project(None) == "gcp-proj"
88+
cloudRunDeployer = DeployerFactory.get_deployer("cloud_run")
89+
assert cloudRunDeployer._resolve_project(None) == "gcp-proj"
9090
mocked_echo.assert_called_once()
9191

9292

93-
# cli_deploy.run with gcp
93+
# cli_deploy.run with cloud_run
9494
@pytest.mark.parametrize("include_requirements", [True, False])
95-
def test_deploy_run_gcp_happy_path(
95+
def test_deploy_cloud_run_happy_path(
9696
monkeypatch: pytest.MonkeyPatch,
9797
agent_dir: Callable[[bool], Path],
9898
include_requirements: bool,
9999
) -> None:
100100
"""
101-
End-to-end execution test for `cli_deploy.run` on gcp covering both presence and
101+
End-to-end execution test for `cli_deploy.run` with cloud_run covering both presence and
102102
absence of *requirements.txt*.
103103
"""
104104
tmp_dir = Path(tempfile.mkdtemp())
@@ -121,7 +121,7 @@ def _recording_copytree(*args: Any, **kwargs: Any):
121121

122122
cli_deploy.run(
123123
agent_folder=str(src_dir),
124-
provider="gcp",
124+
provider="cloud_run",
125125
project="proj",
126126
region="asia-northeast1",
127127
service_name="svc",
@@ -156,7 +156,7 @@ def test_deploy_run_docker_happy_path(
156156
include_requirements: bool,
157157
) -> None:
158158
"""
159-
End-to-end execution test for `cli_deploy.run` on docker covering both presence and
159+
End-to-end execution test for `cli_deploy.run` with docker covering both presence and
160160
absence of *requirements.txt*.
161161
"""
162162
tmp_dir = Path(tempfile.mkdtemp())
@@ -206,7 +206,7 @@ def _recording_copytree(*args: Any, **kwargs: Any):
206206
shutil.rmtree(tmp_dir, ignore_errors=True)
207207

208208

209-
def test_deploy_run_gcp_cleans_temp_dir(
209+
def test_deploy_cloud_run_cleans_temp_dir(
210210
monkeypatch: pytest.MonkeyPatch,
211211
agent_dir: Callable[[bool], Path],
212212
) -> None:
@@ -224,7 +224,7 @@ def _fake_rmtree(path: str | Path, *a: Any, **k: Any) -> None:
224224

225225
cli_deploy.run(
226226
agent_folder=str(src_dir),
227-
provider="gcp",
227+
provider="cloud_run",
228228
project="proj",
229229
region=None,
230230
service_name="svc",

0 commit comments

Comments
 (0)