Skip to content

Commit e93f861

Browse files
Jacksunweicopybara-github
authored andcommitted
chore: Removes unused to_agent_config method in BaseAgentConfig
PiperOrigin-RevId: 797502656
1 parent 54ed079 commit e93f861

File tree

2 files changed

+19
-11
lines changed

2 files changed

+19
-11
lines changed

src/google/adk/agents/base_agent_config.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,3 @@ class BaseAgentConfig(BaseModel):
7979
default=None,
8080
description='Optional. The after_agent_callbacks of the agent.',
8181
)
82-
83-
def to_agent_config(
84-
self, custom_agent_config_cls: Type[TBaseAgentConfig]
85-
) -> TBaseAgentConfig:
86-
"""Converts this config to the concrete agent config type.
87-
88-
NOTE: this is for ADK framework use only.
89-
"""
90-
return custom_agent_config_cls.model_validate(self.model_dump())

tests/unittests/agents/test_agent_config.py

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# Copyright 2025 Google LLC
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
115
from typing import Literal
216

317
from google.adk.agents.agent_config import AgentConfig
@@ -115,9 +129,12 @@ class MyCustomAgentConfig(BaseAgentConfig):
115129

116130
config = AgentConfig.model_validate(config_data)
117131

118-
assert isinstance(config.root, BaseAgentConfig)
132+
# pylint: disable=unidiomatic-typecheck Needs exact class matching.
133+
assert type(config.root) is BaseAgentConfig
119134
assert config.root.agent_class == "mylib.agents.MyCustomAgent"
120135
assert config.root.model_extra == {"other_field": "other value"}
121136

122-
my_custom_config = config.root.to_agent_config(MyCustomAgentConfig)
137+
my_custom_config = MyCustomAgentConfig.model_validate(
138+
config.root.model_dump()
139+
)
123140
assert my_custom_config.other_field == "other value"

0 commit comments

Comments
 (0)