Skip to content

fix: remove classmethod from model_validator #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove classmethod from model_validator #1552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions google/genai/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9559,13 +9559,12 @@ class Metric(_common.BaseModel):
_version: Optional[str] = PrivateAttr(default=None)
"""An optional string indicating the version of the metric."""

@model_validator(mode='after') # type: ignore[arg-type]
@classmethod
def validate_name(cls, model: 'Metric') -> 'Metric':
if not model.name:
@model_validator(mode='after')
def validate_name(self) -> Self:
if not self.name:
raise ValueError('Metric name cannot be empty.')
model.name = model.name.lower()
return model
self.name = self.name.lower()
return self

def to_yaml_file(self, file_path: str, version: Optional[str] = None) -> None:
"""Dumps the metric object to a YAML file.
Expand Down