Skip to content

tagging.py: coverart rework documentation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 18, 2025
Merged

tagging.py: coverart rework documentation #57

merged 8 commits into from
Aug 18, 2025

Conversation

dconrad5
Copy link
Contributor

@dconrad5 dconrad5 commented Jan 4, 2025

depends on PR #55

@dconrad5 dconrad5 mentioned this pull request Jan 4, 2025
Merged
@auouymous
Copy link
Member

Is this updated and ready for review now that gpodder/gpodder#1701 has been merged?

@dconrad5
Copy link
Contributor Author

dconrad5 commented Mar 4, 2025 •
edited
Loading

It is now, I just needed to restore the setting "auto_embed_coverart".

No wait, I think I need to rebase it. That should be quick.

@dconrad5
Copy link
Contributor Author

dconrad5 commented Mar 4, 2025

Ok, now it should be good to review.

auouymous
auouymous requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@auouymous auouymous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably stop using "git master branch", because the auto_embed_coverart used it and was merged in 2013. Perhaps something like "post 3.11.5", "after 3.11.5", or suggestions welcome since those might be seen as 3.11.5 supporting them to some users.

@dconrad5
Copy link
Contributor Author

We should probably stop using "git master branch", because the auto_embed_coverart used it and was merged in 2013. Perhaps something like "post 3.11.5", "after 3.11.5", or suggestions welcome since those might be seen as 3.11.5 supporting them to some users.

Ok, I'll try to make that clearer.

auouymous
auouymous requested changes Apr 19, 2025
View reviewed changes
Copy link
Member

@auouymous auouymous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That "newer than" is perfect, and thank you for looking up the versions for other settings.

@dconrad5
Copy link
Contributor Author

dconrad5 commented Jul 3, 2025

Are there any outstanding changes we would like in this PR?

elelay
elelay reviewed Aug 18, 2025
View reviewed changes
elelay
elelay reviewed Aug 18, 2025
View reviewed changes
@elelay elelay merged commit 3398eae into gpodder:master Aug 18, 2025
@elelay
Copy link
Member

elelay commented Aug 18, 2025

Great, thanks :-)

@dconrad5 dconrad5 deleted the mutagen_coverart branch August 18, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elelay elelay elelay left review comments

@auouymous auouymous auouymous requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconrad5 @auouymous @elelay