-
Notifications
You must be signed in to change notification settings - Fork 51
Update run-from-git instructions #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e8af647
to
fbaef5e
Compare
Thank you for doing this, I was going to add the optional deps after redoing them (gpodder/gpodder#1761), but haven't had time to do either. Would the following also work? - python3 -m pip install .'[eyed3]' .'[gui]' .'[html5lib]' .'[mutagen]' .'[coverart]' .'[yt-dlp']
+ python3 -m pip install '.[eyed3,gui,html5lib,mutagen,coverart,yt-dlp]' Can the venv be used on Windows and Linux? Perhaps prepend "Optional:" to the comment, and if required on mac, append "(required on Mac)"? Do you know if both pip install steps are required, or if only one the following four steps is? I have never used pip but I think the period in
|
The syntax of pip reading from a .toml file is pretty opaque to me, but this does seem to work, yeah.
I imagine so - I can reword it to be more obvious that it's not a mac-specific thing.
Just tried it, it does seem that you don't need both - I'll try rewording it a bit. |
With the switch fromm requirements.txt to pyproject.toml, the instructions no longer were accurate. Also add instructions on how to use virtual environment and how to install optional dependencies.
Ok, take a look now - I incorporated the changes and squashed all commits together. |
typo Co-authored-by: Eric Le Lay <[email protected]>
Thanks @dconrad5 |
With the switch fromm requirements.txt to pyproject.toml, the instructions no longer were accurate.
Also add instructions on how to use virtual environment and how to install optional dependencies.