fix: openapi revamp: fix incorrect error message when JSON args are invalid (#844)

g-linville · web-flow · commit dbf46d154265 · 2024-09-09T11:12:15.000-04:00
Signed-off-by: Grant Linville &lt;grant@acorn.io&gt;
diff --git a/pkg/openapi/run.go b/pkg/openapi/run.go
@@ -39,7 +39,7 @@ func Run(operationID, defaultHost, args string, t *openapi3.T, envs []string) (s
 	validationResult, err := gojsonschema.Validate(gojsonschema.NewStringLoader(schemaJSON), gojsonschema.NewStringLoader(args))
 	if err != nil {
 		// We don't return an error here because we want the LLM to be able to maintain control and try again.
-		return fmt.Sprintf("ERROR: failed to validate arguments. Make sure your arguments are valid JSON. %v", err), false, nil
+		return fmt.Sprintf("ERROR: failed to validate arguments. Make sure your arguments are valid JSON. %v", err), true, nil
 	}
 
 	if !validationResult.Valid() {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func Run(operationID, defaultHost, args string, t *openapi3.T, envs []string) (s`
`39`	`39`	`validationResult, err := gojsonschema.Validate(gojsonschema.NewStringLoader(schemaJSON), gojsonschema.NewStringLoader(args))`
`40`	`40`	`if err != nil {`
`41`	`41`	`// We don't return an error here because we want the LLM to be able to maintain control and try again.`
`42`		`- return fmt.Sprintf("ERROR: failed to validate arguments. Make sure your arguments are valid JSON. %v", err), false, nil`
	`42`	`+ return fmt.Sprintf("ERROR: failed to validate arguments. Make sure your arguments are valid JSON. %v", err), true, nil`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`if !validationResult.Valid() {`