Skip to content

Commit e1c7a75

Browse files
committed
Enhance output of 'moduleDependencies' task
1 parent 21d1947 commit e1c7a75

File tree

3 files changed

+26
-3
lines changed

3 files changed

+26
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Java Module Dependencies Gradle Plugin - Changelog
22

3+
## Version 1.6.4
4+
* Enhance output of 'moduleDependencies' task
5+
* Update 'org.ow2.asm:asm' to 9.7
6+
37
## Version 1.6.3
48
* Update module name mappings
59

src/main/java/org/gradlex/javamodule/dependencies/internal/diagnostics/RenderableModuleDependencyResult.java

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
import org.gradle.api.NonNullApi;
2020
import org.gradle.api.artifacts.component.ComponentIdentifier;
21+
import org.gradle.api.artifacts.component.ComponentSelector;
2122
import org.gradle.api.artifacts.component.ModuleComponentIdentifier;
23+
import org.gradle.api.artifacts.component.ModuleComponentSelector;
2224
import org.gradle.api.artifacts.result.DependencyResult;
2325
import org.gradle.api.artifacts.result.ResolvedArtifactResult;
2426
import org.gradle.api.artifacts.result.ResolvedDependencyResult;
@@ -65,6 +67,7 @@ public Set<RenderableDependency> getChildren() {
6567

6668
@Override
6769
public String getName() {
70+
ComponentSelector requested = getRequested();
6871
ComponentIdentifier selected = getActual();
6972
ResolvedArtifactResult artifact = resolvedJars.stream().filter(a ->
7073
a.getId().getComponentIdentifier().equals(selected)).findFirst().orElse(null);
@@ -78,15 +81,30 @@ public String getName() {
7881
return "[CLASSPATH] " + selected.getDisplayName();
7982
} else {
8083
String version = "";
84+
String coordinates = selected.getDisplayName();
85+
String jarName = artifact.getFile().getName();
8186
if (selected instanceof ModuleComponentIdentifier) {
82-
version = " (" + ((ModuleComponentIdentifier) selected).getVersion() + ")";
87+
String selectedVersion = ((ModuleComponentIdentifier) selected).getVersion();
88+
version = " (" + selectedVersion + ")";
89+
if (requested instanceof ModuleComponentSelector) {
90+
String requestedVersion = ((ModuleComponentSelector) requested).getVersion();
91+
if (!requestedVersion.isEmpty() && !selectedVersion.equals(requestedVersion)) {
92+
version = " (" + requestedVersion + " -> " + selectedVersion + ")";
93+
}
94+
}
95+
coordinates = ((ModuleComponentIdentifier) selected).getModuleIdentifier().toString();
8396
}
8497
String auto = isRealModule(artifact.getFile()) ? "" : "[AUTO] ";
85-
return auto + actualModuleName + version;
98+
return auto + actualModuleName + version + " | " + coordinates +
99+
(isConstraint() ? "" : " | " + jarName);
86100
}
87101
}
88102
} catch (IOException e) {
89103
throw new RuntimeException(e);
90104
}
91105
}
106+
107+
private boolean isConstraint() {
108+
return getResolutionState() == ResolutionState.RESOLVED_CONSTRAINT;
109+
}
92110
}

src/main/java/org/gradlex/javamodule/dependencies/internal/diagnostics/StyledNodeRenderer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ public void renderNode(StyledTextOutput output, RenderableDependency node, boole
3636
} else if (name.startsWith("[CLASSPATH]")) {
3737
output.withStyle(Failure).text(name);
3838
} else {
39-
output.text(name);
39+
int idx = name.indexOf('|');
40+
output.text(name.substring(0, idx)).withStyle(Description).text(name.substring(idx));
4041
}
4142
switch (node.getResolutionState()) {
4243
case FAILED:

0 commit comments

Comments
 (0)