@@ -5001,7 +5001,7 @@ static const ggml_type other_types[] = {
5001
5001
};
5002
5002
5003
5003
// Test cases for evaluation: should try to cover edge cases while using small input sizes to keep the runtime low
5004
- static std::vector<std::unique_ptr<test_case>> make_test_cases_eval (bool test_sgd = true ) {
5004
+ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval () {
5005
5005
std::vector<std::unique_ptr<test_case>> test_cases;
5006
5006
std::default_random_engine rng (0 );
5007
5007
@@ -5794,8 +5794,7 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval(bool test_sg
5794
5794
test_cases.emplace_back (new test_cross_entropy_loss_back (GGML_TYPE_F32, {30000 , 1 , 1 , 1 }));
5795
5795
5796
5796
test_cases.emplace_back (new test_opt_step_adamw (GGML_TYPE_F32, {10 , 5 , 4 , 3 }));
5797
- if (test_sgd)
5798
- test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
5797
+ test_cases.emplace_back (new test_opt_step_sgd (GGML_TYPE_F32, { 10 , 5 , 4 , 3 }));
5799
5798
5800
5799
#if 0
5801
5800
// these tests are disabled to save execution time, sbut they can be handy for debugging
@@ -5930,10 +5929,6 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
5930
5929
}
5931
5930
};
5932
5931
5933
- char const * name = ggml_backend_name (backend);
5934
- bool const vulkan = strstr (name, " ulkan" );
5935
- bool const sgd = !vulkan;
5936
-
5937
5932
if (mode == MODE_TEST) {
5938
5933
auto test_cases = make_test_cases_eval ();
5939
5934
filter_test_cases (test_cases, params_filter);
@@ -5959,7 +5954,7 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
5959
5954
}
5960
5955
5961
5956
if (mode == MODE_GRAD) {
5962
- auto test_cases = make_test_cases_eval (sgd );
5957
+ auto test_cases = make_test_cases_eval ();
5963
5958
filter_test_cases (test_cases, params_filter);
5964
5959
size_t n_ok = 0 ;
5965
5960
for (auto & test : test_cases) {
0 commit comments