Skip to content

Commit 0e5bf54

Browse files
jalevinadamyeats
authored andcommitted
fix syntax for test env vars
1 parent e386570 commit 0e5bf54

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/cloud-e2e.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ jobs:
109109
--log-level debug \
110110
--pw-execute "npm run e2e" \
111111
--pw-prepare "npm ci --no-audit --fund=false; npx playwright install" \
112-
--test-env-vars 'CI=true DS_INSTANCE_HOST=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_HOST }} DS_INSTANCE_PASSWORD=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_PASSWORD }} DS_INSTANCE_PORT=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_PORT }} DS_INSTANCE_USERNAME=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_USERNAME }}' \
112+
--test-env 'CI=true,DS_INSTANCE_HOST=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_HOST }},DS_INSTANCE_PASSWORD=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_PASSWORD }},DS_INSTANCE_PORT=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_PORT }},DS_INSTANCE_USERNAME=${{ fromJSON(steps.get-secrets.outputs.secrets).DS_INSTANCE_USERNAME }}' \
113113
--test-runner playwright
114114
115115
- name: Archive Playwright artifacts
@@ -118,4 +118,4 @@ jobs:
118118
with:
119119
name: playwright-report
120120
path: playwright-report/
121-
retention-days: 30
121+
retention-days: 1

tests/e2e/configEditor.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ test.describe('Config Editor', () => {
2424

2525
if (process.env.DS_INSTANCE_PASSWORD) {
2626
await page.getByPlaceholder('password').fill(process.env.DS_INSTANCE_PASSWORD);
27+
28+
await page.getByRole('combobox', { name: 'Private data source connect' }).click();
29+
await page.getByText('datasources-pdc-network-aws-datasource').click();
2730
}
2831

2932
await configPage.saveAndTest();

0 commit comments

Comments
 (0)