use dots in stat name

Author: ashwanthgoli

pkg/dataobj/internal/dataset/read_stats.go

@@ -7,35 +7,35 @@ import (
 // xcap statistics for dataset reader operations.
 var (
 	// Column statistics
-	StatPrimaryColumns   = xcap.NewStatisticInt64("primary_columns", xcap.AggregationTypeSum)
-	StatSecondaryColumns = xcap.NewStatisticInt64("secondary_columns", xcap.AggregationTypeSum)
+	StatPrimaryColumns   = xcap.NewStatisticInt64("primary.columns", xcap.AggregationTypeSum)
+	StatSecondaryColumns = xcap.NewStatisticInt64("secondary.columns", xcap.AggregationTypeSum)
 
 	// Page statistics
-	StatPrimaryColumnPages   = xcap.NewStatisticInt64("primary_column_pages", xcap.AggregationTypeSum)
-	StatSecondaryColumnPages = xcap.NewStatisticInt64("secondary_column_pages", xcap.AggregationTypeSum)
+	StatPrimaryColumnPages   = xcap.NewStatisticInt64("primary.column.pages", xcap.AggregationTypeSum)
+	StatSecondaryColumnPages = xcap.NewStatisticInt64("secondary.column.pages", xcap.AggregationTypeSum)
 
 	// Row statistics
-	StatMaxRows           = xcap.NewStatisticInt64("max_rows", xcap.AggregationTypeSum)
-	StatRowsAfterPruning  = xcap.NewStatisticInt64("rows_after_pruning", xcap.AggregationTypeSum)
-	StatPrimaryRowsRead   = xcap.NewStatisticInt64("primary_rows_read", xcap.AggregationTypeSum)
-	StatSecondaryRowsRead = xcap.NewStatisticInt64("secondary_rows_read", xcap.AggregationTypeSum)
-	StatPrimaryRowBytes   = xcap.NewStatisticInt64("primary_row_bytes_read", xcap.AggregationTypeSum)
-	StatSecondaryRowBytes = xcap.NewStatisticInt64("secondary_row_bytes_read", xcap.AggregationTypeSum)
+	StatMaxRows           = xcap.NewStatisticInt64("row.max", xcap.AggregationTypeSum)
+	StatRowsAfterPruning  = xcap.NewStatisticInt64("rows.after.pruning", xcap.AggregationTypeSum)
+	StatPrimaryRowsRead   = xcap.NewStatisticInt64("primary.rows.read", xcap.AggregationTypeSum)
+	StatSecondaryRowsRead = xcap.NewStatisticInt64("secondary.rows.read", xcap.AggregationTypeSum)
+	StatPrimaryRowBytes   = xcap.NewStatisticInt64("primary.row.read.bytes", xcap.AggregationTypeSum)
+	StatSecondaryRowBytes = xcap.NewStatisticInt64("secondary.row.read.bytes", xcap.AggregationTypeSum)
 
 	// Download/Page scan statistics
-	StatPagesScanned          = xcap.NewStatisticInt64("pages_scanned", xcap.AggregationTypeSum)
-	StatPagesFoundInCache     = xcap.NewStatisticInt64("pages_found_in_cache", xcap.AggregationTypeSum)
-	StatBatchDownloadRequests = xcap.NewStatisticInt64("batch_download_requests", xcap.AggregationTypeSum)
-	StatPageDownloadTime      = xcap.NewStatisticInt64("page_download_time_ns", xcap.AggregationTypeSum)
+	StatPagesScanned         = xcap.NewStatisticInt64("pages.scanned", xcap.AggregationTypeSum)
+	StatPagesFoundInCache    = xcap.NewStatisticInt64("pages.cache.hit", xcap.AggregationTypeSum)
+	StatPageDownloadRequests = xcap.NewStatisticInt64("pages.download.requests", xcap.AggregationTypeSum)
+	StatPageDownloadTime     = xcap.NewStatisticInt64("pages.download.duration.ns", xcap.AggregationTypeSum)
 
 	// Page download byte statistics
-	StatPrimaryColumnPagesDownloaded     = xcap.NewStatisticInt64("primary_column_pages_downloaded", xcap.AggregationTypeSum)
-	StatSecondaryColumnPagesDownloaded   = xcap.NewStatisticInt64("secondary_column_pages_downloaded", xcap.AggregationTypeSum)
-	StatPrimaryColumnBytes               = xcap.NewStatisticInt64("primary_column_bytes", xcap.AggregationTypeSum)
-	StatSecondaryColumnBytes             = xcap.NewStatisticInt64("secondary_column_bytes", xcap.AggregationTypeSum)
-	StatPrimaryColumnUncompressedBytes   = xcap.NewStatisticInt64("primary_column_uncompressed_bytes", xcap.AggregationTypeSum)
-	StatSecondaryColumnUncompressedBytes = xcap.NewStatisticInt64("secondary_column_uncompressed_bytes", xcap.AggregationTypeSum)
+	StatPrimaryPagesDownloaded           = xcap.NewStatisticInt64("primary.pages.downloaded", xcap.AggregationTypeSum)
+	StatSecondaryPagesDownloaded         = xcap.NewStatisticInt64("secondary.pages.downloaded", xcap.AggregationTypeSum)
+	StatPrimaryColumnBytes               = xcap.NewStatisticInt64("primary.pages.compressed.bytes", xcap.AggregationTypeSum)
+	StatSecondaryColumnBytes             = xcap.NewStatisticInt64("secondary.pages.compressed.bytes", xcap.AggregationTypeSum)
+	StatPrimaryColumnUncompressedBytes   = xcap.NewStatisticInt64("primary.pages.uncompressed.bytes", xcap.AggregationTypeSum)
+	StatSecondaryColumnUncompressedBytes = xcap.NewStatisticInt64("secondary.pages.uncompressed.bytes", xcap.AggregationTypeSum)
 
 	// Read operation statistics
-	StatReadCalls = xcap.NewStatisticInt64("read_calls", xcap.AggregationTypeSum)
+	StatReadCalls = xcap.NewStatisticInt64("read.calls", xcap.AggregationTypeSum)
 )

pkg/dataobj/internal/dataset/reader_downloader.go

@@ -232,11 +232,11 @@ func (dl *readerDownloader) downloadBatch(ctx context.Context, requestor *reader
 	if region := xcap.RegionFromContext(ctx); region != nil {
 		for _, page := range batch {
 			if page.column.primary {
-				region.Record(StatPrimaryColumnPagesDownloaded.Observe(1))
+				region.Record(StatPrimaryPagesDownloaded.Observe(1))
 				region.Record(StatPrimaryColumnBytes.Observe(int64(page.inner.PageDesc().CompressedSize)))
 				region.Record(StatPrimaryColumnUncompressedBytes.Observe(int64(page.inner.PageDesc().UncompressedSize)))
 			} else {
-				region.Record(StatSecondaryColumnPagesDownloaded.Observe(1))
+				region.Record(StatSecondaryPagesDownloaded.Observe(1))
 				region.Record(StatSecondaryColumnBytes.Observe(int64(page.inner.PageDesc().CompressedSize)))
 				region.Record(StatSecondaryColumnUncompressedBytes.Observe(int64(page.inner.PageDesc().UncompressedSize)))
 			}
@@ -595,7 +595,7 @@ func (page *readerPage) ReadPage(ctx context.Context) (PageData, error) {
 		return page.data, nil
 	}
 
-	region.Record(StatBatchDownloadRequests.Observe(1))
+	region.Record(StatPageDownloadRequests.Observe(1))
 	if err := page.column.dl.downloadBatch(ctx, page); err != nil {
 		return nil, err
 	}