Upstream/2 write a predictor class to mimic the gec model #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage Create Python package & bump to Python 3.8
…t_test_for_tokenToIndexers_and_tokenization Features/add unit test for token to indexers and tokenization
…y gec_model, get_token_action removed and placed in model.
There's a bug in here somewhere though because the output isn't exactly the same. I suspect there's an off by one error happening when the indices for edit operations are generated.
Co-authored-by: Sanjna Kashyap <[email protected]>
…r_from_gec_model Allennlp Predictor class that mimics gec_model
…tingService/gector into feature/fix-gec-predictor
…-predictor Feature/fix gec predictor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before, our team has been working on updating GECToR dependencies to the latest versions (Inference only). This is the second PR, one more PR is coming soon.
Link to the successful run: here
We also checked the impact for the training process. No breaks were identified.
First PR: Add unit tests and regression test. Additionally, bump Python version.
Second PR: Write a predictor class to mimic the GEC_model.
Third PR: Unpin all the dependency requirements
How to review:
Unit test:
pytest -v testsRegression test:
python regression_tests/test_gector_roberta.pypython regression_tests/test_regression_data_predictor.pyOur plan is to submit one more PR. Suggestions and comments are welcome!