-
Notifications
You must be signed in to change notification settings - Fork 218
docs(gfql): Consolidated GFQL documentation improvements #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b3feee6
docs(gfql): Consolidate all documentation improvements
lmeyerov 0d12ba5
docs: restore missing Let() documentation and fix API references
lmeyerov 324acbb
docs: add GIB citations and relocate wire protocol examples
lmeyerov 7a94b8b
docs(gfql): Improve translate.rst Cypher comparison accuracy
lmeyerov 986fa38
docs(gfql): Improve cypher_mapping.md clarity and structure
lmeyerov f2baffb
fix(docs): Replace emojis with LaTeX-compatible text in comparison table
lmeyerov 1c81117
docs(gfql): Add footnotes to clarify feature comparison table
lmeyerov 1322c1c
docs: Add graph DataFrame loading documentation
lmeyerov 9d4eb89
docs: Add cross-references to loading graph data guide
lmeyerov b277cd4
docs: Enhance loading graph data guide with comprehensive patterns
lmeyerov 86d6b04
fix(docs): Correct ref() syntax from ref().gfql() to ref(name, [...])
lmeyerov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| # GFQL Built-in Calls Documentation Audit Report | ||
|
|
||
| ## Executive Summary | ||
|
|
||
| The `builtin_calls.rst` documentation contains significant inaccuracies and is missing critical methods. Of the 12 methods documented, 4 are not in the safelist (33% error rate), and 16 important methods from the safelist are completely missing from the documentation. | ||
|
|
||
| ## 1. Accuracy Issues - Methods NOT in Safelist | ||
|
|
||
| ### ❌ pagerank | ||
| - **Status**: NOT IN SAFELIST | ||
| - **Issue**: Documented as `call('pagerank')` but this is incorrect | ||
| - **Correct Usage**: Should be `call('compute_cugraph', {'alg': 'pagerank'})` | ||
| - **Location**: Lines 38-44 | ||
| - **Examples affected**: Lines 20, 26, 42-44, 179, 189, 199, 221, 226 | ||
|
|
||
| ### ❌ umap | ||
| - **Status**: NOT IN SAFELIST | ||
| - **Issue**: Documented as a direct call method | ||
| - **Reality**: UMAP is a feature/capability, not a direct call method | ||
| - **Location**: Lines 87-93 | ||
|
|
||
| ### ❌ add_graph | ||
| - **Status**: NOT IN SAFELIST | ||
| - **Issue**: Method does not exist in safelist | ||
| - **Location**: Lines 114-119 | ||
|
|
||
| ### ❌ sample | ||
| - **Status**: NOT IN SAFELIST | ||
| - **Issue**: Method does not exist in safelist | ||
| - **Location**: Lines 138-143 | ||
|
|
||
| ## 2. Correctly Documented Methods (IN SAFELIST ✓) | ||
|
|
||
| - ✓ get_degrees (lines 46-53) | ||
| - ✓ filter_nodes_by_dict (lines 58-63) | ||
| - ✓ filter_edges_by_dict (lines 65-70) | ||
| - ✓ hop (lines 75-82) | ||
| - ✓ fa2_layout (lines 95-101) | ||
| - ✓ materialize_nodes (lines 106-112) | ||
| - ✓ prune_self_edges (lines 121-126) | ||
| - ✓ name (lines 131-136) | ||
|
|
||
| ## 3. Missing Critical Methods from Safelist | ||
|
|
||
| ### Graph Algorithm Methods | ||
| - **compute_cugraph** - Critical for GPU algorithms (pagerank, louvain, etc.) | ||
| - **compute_igraph** - For igraph-based algorithms | ||
|
|
||
| ### Layout Methods | ||
| - **layout_cugraph** - GPU-accelerated layouts | ||
| - **layout_igraph** - igraph-based layouts | ||
| - **layout_graphviz** - Graphviz layouts (dot, neato, etc.) | ||
|
|
||
| ### Degree Analysis Methods | ||
| - **get_indegrees** - Calculate in-degrees only | ||
| - **get_outdegrees** - Calculate out-degrees only | ||
|
|
||
| ### Visual Encoding Methods | ||
| - **encode_point_color** - Map node values to colors | ||
| - **encode_edge_color** - Map edge values to colors | ||
| - **encode_point_size** - Map node values to sizes | ||
| - **encode_point_icon** - Map node values to icons | ||
|
|
||
| ### Graph Transformation Methods | ||
| - **collapse** - Collapse nodes by shared attributes | ||
| - **drop_nodes** - Remove specified nodes | ||
| - **keep_nodes** - Keep only specified nodes | ||
|
|
||
| ### Analysis Methods | ||
| - **get_topological_levels** - DAG analysis | ||
| - **description** - Set visualization description | ||
|
|
||
| ## 4. Documentation Quality Issues | ||
|
|
||
| ### Missing Parameter Tables | ||
| The documentation lacks structured parameter tables showing: | ||
| - Required vs optional parameters | ||
| - Parameter types | ||
| - Default values | ||
| - Valid value ranges/options | ||
|
|
||
| ### Incorrect Examples | ||
| All examples using `call('pagerank')` are wrong and should use: | ||
| ```python | ||
| call('compute_cugraph', {'alg': 'pagerank'}) | ||
| ``` | ||
|
|
||
| ### Missing Safelist Validation Details | ||
| No mention of: | ||
| - How validation works | ||
| - Error codes (E303, E105, E201) | ||
| - What happens with invalid parameters | ||
|
|
||
| ### Misleading GPU Acceleration Section | ||
| Lists methods as GPU-accelerated that either: | ||
| - Don't exist in safelist (pagerank) | ||
| - May not actually be GPU-accelerated (filter operations) | ||
|
|
||
| ## 5. Recommendations | ||
|
|
||
| 1. **Immediate Fixes Required**: | ||
| - Replace all `pagerank` references with `compute_cugraph` examples | ||
| - Remove non-existent methods (umap, add_graph, sample) | ||
| - Add all missing methods from safelist | ||
|
|
||
| 2. **Add Parameter Documentation**: | ||
| - Create tables for each method showing parameters | ||
| - Include type information and validation rules | ||
| - Show which parameters are required vs optional | ||
|
|
||
| 3. **Improve Examples**: | ||
| - Fix all incorrect pagerank examples | ||
| - Add examples for compute_cugraph with different algorithms | ||
| - Show proper error handling | ||
|
|
||
| 4. **Add Validation Section**: | ||
| - Explain safelist validation | ||
| - Document error codes and their meanings | ||
| - Show how to handle validation errors | ||
|
|
||
| 5. **Clarify GPU Acceleration**: | ||
| - Only list methods that actually support GPU | ||
| - Explain which algorithms are available through compute_cugraph | ||
| - Remove misleading claims about filter operations | ||
|
|
||
| ## 6. Example of Corrected Documentation | ||
|
|
||
| Instead of: | ||
| ```python | ||
| call('pagerank') | ||
| call('pagerank', {'damping': 0.85, 'iterations': 20}) | ||
| ``` | ||
|
|
||
| Should be: | ||
| ```python | ||
| call('compute_cugraph', {'alg': 'pagerank'}) | ||
| call('compute_cugraph', {'alg': 'pagerank', 'params': {'damping': 0.85, 'max_iter': 20}}) | ||
| ``` | ||
|
|
||
| ## 7. Statistics | ||
|
|
||
| - **Total methods documented**: 12 | ||
| - **Methods not in safelist**: 4 (33%) | ||
| - **Methods correctly documented**: 8 (67%) | ||
| - **Methods missing from docs**: 16 | ||
| - **Total methods in safelist**: 24 | ||
| - **Documentation coverage**: 8/24 (33%) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad file