Add MAGIC Telescope detector class #837
Open
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aske-Rosted
reviewed
Oct 14, 2025
Collaborator
Aske-Rosted
left a comment
Aske-Rosted
left a comment
There was a problem hiding this comment.
A couple of comments otherwise looks good.
| def _charge(self, x: torch.tensor) -> torch.tensor: | ||
| """Add a small epsilon to avoid log(0).""" | ||
| epsilon = 1e-6 | ||
| return torch.log10(x + epsilon) |
Collaborator
There was a problem hiding this comment.
If you would always expect any user to have zero-padding in the data when using the MAGIC detector class then this approach is fine otherwise adding the epsilon as an optional toggle is probably cleaner.
Author
There was a problem hiding this comment.
Added an input parameter use_charge_epsilon which seems to be settable now from the config file. Hoping this is the right way to go about it.
Author
|
Thank you for the detailed review! I will take a look asap and let you know if I have questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a base PR which can later facilitate the addition of the MAGIC reader, addressing #836:
MAGIC(Detector)I'm not sure if anything should be updated in the documentation at this point, but I can definitely take care of that in either case when the reader is added.