-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
meta:triagedThis issue has been triaged (has a good description, as well as labels for priority, size and type)This issue has been triaged (has a good description, as well as labels for priority, size and type)p2Medium priorityMedium prioritysize:smallSmallSmalltype:refactorChanges not visible to usersChanges not visible to users
Description
From @hopeyen's comment on a PR:
I'm thinking about the data structure being used here, and wondering what do you think about creating a struct for subgraph deployments that contains the fields of id, allocated, stake, block_number, block_hash, poi, ...? It feels like a more tidy way to tracking everything we care about for a particular deployment, and we just need to pass in a vec instead of all fields in vecs.
this might be a separate refactor effort though, just raising it since I was thinking about it
which was made in relation to this function's signature:
pub async fn process_comparison_results(
blocks_str: String,
num_topics: usize,
result_strings: Vec<Result<ComparisonResult, OperationError>>,
notifier: Notifier,
db: SqlitePool,
allocated_subgraphs: HashSet<String>,
)We should:
- create a new struct that holds data for a specific Subgraph deployment and use that instead of separate fields as arguments/values
- add
allocated_subgraphsto Radio operator and send the query insidenetwork_check
Metadata
Metadata
Assignees
Labels
meta:triagedThis issue has been triaged (has a good description, as well as labels for priority, size and type)This issue has been triaged (has a good description, as well as labels for priority, size and type)p2Medium priorityMedium prioritysize:smallSmallSmalltype:refactorChanges not visible to usersChanges not visible to users