SaslHandshakeRequest v1 uses default Kafka protocol

everesio · everesio · commit 070749a18438 · 2018-05-10T22:41:54.000+02:00
diff --git a/proxy/processor_default.go b/proxy/processor_default.go
@@ -94,10 +94,9 @@ func (handler *DefaultRequestHandler) handleRequest(dst DeadlineWriter, src Dead
 		return readErr, err
 	}
 	if requestKeyVersion.ApiKey == apiKeySaslHandshake {
-		if requestKeyVersion.ApiVersion != 0 {
-			return false, errors.New("only SASL V0 Handshake is supported")
+		if requestKeyVersion.ApiVersion == 0 {
+			return false, ctx.putNextHandlers(saslAuthV0RequestHandler, saslAuthV0ResponseHandler)
 		}
-		return false, ctx.putNextHandlers(saslAuthV0RequestHandler, saslAuthV0ResponseHandler)
 	}
 	return false, ctx.putNextHandlers(defaultRequestHandler, defaultResponseHandler)
 }

Original file line number	Diff line number	Diff line change
`@@ -94,10 +94,9 @@ func (handler *DefaultRequestHandler) handleRequest(dst DeadlineWriter, src Dead`
`94`	`94`	`return readErr, err`
`95`	`95`	`}`
`96`	`96`	`if requestKeyVersion.ApiKey == apiKeySaslHandshake {`
`97`		`- if requestKeyVersion.ApiVersion != 0 {`
`98`		`- return false, errors.New("only SASL V0 Handshake is supported")`
	`97`	`+ if requestKeyVersion.ApiVersion == 0 {`
	`98`	`+ return false, ctx.putNextHandlers(saslAuthV0RequestHandler, saslAuthV0ResponseHandler)`
`99`	`99`	`}`
`100`		`- return false, ctx.putNextHandlers(saslAuthV0RequestHandler, saslAuthV0ResponseHandler)`
`101`	`100`	`}`
`102`	`101`	`return false, ctx.putNextHandlers(defaultRequestHandler, defaultResponseHandler)`
`103`	`102`	`}`