Fix GetNextIndex method to initialize pIndex to 0 and update index validation for array handling

grongierisc · grongierisc · commit b117991e00e5 · 2025-01-09T11:08:05.000+01:00
diff --git a/src/iop/cls/IOP/Message.cls b/src/iop/cls/IOP/Message.cls
@@ -34,9 +34,10 @@ Method GetNextIndex(
 	ByRef pStatus As %Status = {$$$OK}) As %String
 {
     Set f=$F(pPath,"()")  If 'f Set pStatus=$$$ERROR($$$EnsErrGeneral,"Can't iterate on no-array type '"_pPath_"'") Quit ""
-    if pIndex="" Set pIndex=1
+    if pIndex="" Set pIndex=0
     Set tValue = ..GetValueAt($EXTRACT(pPath, 1, $LENGTH(pPath)-2))
-    if pIndex>$LENGTH(tValue) Quit ""
+    Set builtins = ##class(%SYS.Python).Builtins()
+    if pIndex>=builtins.len(tValue) Quit ""
     Quit pIndex+1
 }
 

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,10 @@ Method GetNextIndex(`
`34`	`34`	`ByRef pStatus As %Status = {$$$OK}) As %String`
`35`	`35`	`{`
`36`	`36`	`Set f=$F(pPath,"()") If 'f Set pStatus=$$$ERROR($$$EnsErrGeneral,"Can't iterate on no-array type '"_pPath_"'") Quit ""`
`37`		`- if pIndex="" Set pIndex=1`
	`37`	`+ if pIndex="" Set pIndex=0`
`38`	`38`	`Set tValue = ..GetValueAt($EXTRACT(pPath, 1, $LENGTH(pPath)-2))`
`39`		`- if pIndex>$LENGTH(tValue) Quit ""`
	`39`	`+ Set builtins = ##class(%SYS.Python).Builtins()`
	`40`	`+ if pIndex>=builtins.len(tValue) Quit ""`
`40`	`41`	`Quit pIndex+1`
`41`	`42`	`}`
`42`	`43`