Skip to content

Commit 89d67aa

Browse files
committed
add newline at EOF and section on tests/checkers
1 parent baa13eb commit 89d67aa

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

.github/pull_request_template.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,16 @@ swift review.
5151

5252
6. Self-review your code changes before sending your PR.
5353

54-
7. Delete all of the above before sending your PR.
54+
7. All tests must be passing or you PR cannot be merged. There are two github
55+
checkers that need not be green:
56+
57+
1. We test the freshness of the generated proto code we maintain via the
58+
`vet-proto` check. If the source proto files are updated, but our repo is
59+
not updated, an optional checker will fail. This will be fixed by our
60+
team in a separate PR and will not prevent the merge of your PR.
61+
62+
2. We run a checker that will fail if there is any change in dependencies of
63+
an exported package via the `dependencies` check. If new dependencies are
64+
added that are not appropriate, we may not accept your PR.
65+
66+
8. Delete all of the above before sending your PR.

0 commit comments

Comments
 (0)