-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Open
Labels
Milestone
Description
I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:
- Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in
Code Style > Java > Imports > Import Layout
. - Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in
Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline
, as well as the same option underMethod call arguments
.