-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Open
Description
In #9360 I added this workaround:
grpc-java/core/src/main/java/io/grpc/internal/RetriableStream.java
Lines 565 to 568 in 7c73baa
// TODO(ejona): Workaround Netty memory leak. Message writes always need to be followed by | |
// flushes (or half close), but retry appears to have a code path that the flushes may | |
// not happen. The code needs to be fixed and this removed. See #9340. | |
substream.stream.flush(); |
A flush() must always follow a write (but other flushes and calls could be in-between). I tried to flush everywhere but it didn't work at the time. See also #9340. It is possible there were interactions with #9547 which prevented it from working and just trying again may work.