FFM-11656 Sort Group Serving Rules rules when saving to cache (#117)

* FFM-11656 Sort serving rules in cache code

* FFM-11656 Sort serving rules in cache code

* FFM-11656 1.8.2 bump

Author: erdirowlands

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@harnessio/ff-nodejs-server-sdk",
-  "version": "1.8.1",
+  "version": "1.8.2",
   "description": "Feature flags SDK for NodeJS environments",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.mjs",

package.json

@@ -154,8 +154,6 @@ export class Evaluator {
 
         if (segment?.servingRules?.length) {
           // Use enhanced rules first if they're available
-          segment.servingRules.sort((r1, r2) => r1.priority - r2.priority);
-
           for (const servingRule of segment.servingRules) {
             if (await this.evaluateClauses_v2(servingRule.clauses, target)) {
               return true;

src/evaluator.ts

@@ -58,6 +58,10 @@ export class StorageRepository implements Repository {
     if (await this.isSegmentOutdated(identifier, segment)) {
       return;
     }
+
+    // Sort the serving rules before storing the segment
+    this.sortSegmentServingRules(segment);
+
     const segmentKey = this.formatSegmentKey(identifier);
     if (this.store) {
       await this.store.set(segmentKey, segment);
@@ -165,13 +169,17 @@ export class StorageRepository implements Repository {
     return oldSegment?.version && oldSegment.version >= segment?.version;
   }
 
+  private sortSegmentServingRules(segment: Segment): void {
+    if (segment.servingRules && segment.servingRules.length > 1) {
+      segment.servingRules.sort((r1, r2) => r1.priority - r2.priority);
+    }
+  }
+
   private formatFlagKey(key: string): string {
     return `flags/${key}`;
   }
 
   private formatSegmentKey(key: string): string {
     return `segments/${key}`;
   }
-
-
 }