Skip to content

Commit b8c7f8a

Browse files
[FFM-9621] - Avoid sending empty metric payloads (#89)
* [FFM-9621] - Avoid sending empty metric payloads What Adds a check to make sure metrics data is not empty before sending it. Why We're seeing empty metrics payloads arriving at the BE we should avoid wasting network bandwidth. Testing Manual Co-authored-by: Kevin Nagurski <[email protected]>
1 parent d0019e1 commit b8c7f8a

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@harnessio/ff-nodejs-server-sdk",
3-
"version": "1.3.4",
3+
"version": "1.3.5",
44
"description": "Feature flags SDK for NodeJS environments",
55
"main": "dist/cjs/index.js",
66
"module": "dist/esm/index.mjs",

src/metrics.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ export const MetricsProcessor = (
188188
}
189189

190190
const metrics: Metrics = _summarize();
191-
if (metrics) {
191+
192+
if (metrics && metrics.metricsData.length && metrics.targetData.length) {
192193
log.debug('Start sending metrics data');
193194
api
194195
.postMetrics(environment, cluster, metrics)

src/version.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const VERSION = "1.3.4";
1+
export const VERSION = "1.3.5";

0 commit comments

Comments
 (0)