fix: [FFM_12484]: Node SDK doesn't retry after initialisation failure (#125)

* fix: [FFM_12484]: Node SDK doesn't retry after initialisation failure

* increase what we check on

Author: andybharness

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@harnessio/ff-nodejs-server-sdk",
-  "version": "1.8.6",
+  "version": "1.8.7",
   "description": "Feature flags SDK for NodeJS environments",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.mjs",

package.json

@@ -322,14 +322,22 @@ export default class Client {
       return true;
     }
 
+    // DNS issues, service down, etc
+    if (error.code === 'ENOTFOUND' || error.code === 'ECONNREFUSED') {
+      return true;
+    }
+
     // Auth is a POST request so not covered by isNetworkOrIdempotentRequestError and it's not an aborted connection
     const status = error?.response?.status;
     const url = error?.config?.url ?? '';
 
+    if (url.includes('client/auth') && status === 403) {
+      // No point retrying with wrong SDK key
+      return false;
+    }
+
     if (
-      url.includes('client/auth') &&
-      status >= 500 &&
-      status <= 599
+      url.includes('client/auth') && ((status >= 500 && status <= 599) || (status >= 400 && status <= 499))
     ) {
       return true;
     }
@@ -357,7 +365,7 @@ export default class Client {
     const instance: AxiosInstance = axios.create(axiosConfig);
     axiosRetry(instance, {
       retries: options.axiosRetries,
-      retryDelay: axiosRetry.exponentialDelay,
+      retryDelay: (retryCount, error) => axiosRetry.exponentialDelay((retryCount > 7 ? 7 : retryCount), error, 500), // cap to 7 to avoid exponential delays getting too long
       retryCondition: this.axiosRetryCondition,
       shouldResetTimeout: true,
       onRetry: (retryCount, error, requestConfig) => {

src/client.ts

@@ -45,7 +45,7 @@ export const defaultOptions: Options = {
   store: new FileStore(),
   logger: new ConsoleLog(),
   axiosTimeout: 30000,
-  axiosRetries: 3,
+  axiosRetries: Infinity, // Retry forever unless explicitly overridden
 };
 
 const TARGET_SEGMENT_RULES_QUERY_PARAMETER = 'v2';

src/constants.ts

@@ -1 +1 @@
-export const VERSION = '1.8.6';
+export const VERSION = '1.8.7';