Skip to content

Commit 529c1e3

Browse files
committed
fix: use simpler definitions for ints
1 parent e14a574 commit 529c1e3

File tree

1 file changed

+8
-18
lines changed

1 file changed

+8
-18
lines changed

include/pybind11/numpy.h

Lines changed: 8 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -438,24 +438,14 @@ DECL_NPY_SCALAR(signed char, NPY_BYTE);
438438
DECL_NPY_SCALAR(unsigned char, NPY_UBYTE);
439439

440440
// signed integer types
441-
DECL_NPY_SCALAR(std::int16_t, NPY_SHORT);
442-
DECL_NPY_SCALAR(std::int32_t, NPY_INT);
443-
DECL_NPY_SCALAR(std::int64_t, NPY_LONG);
444-
#if defined(__linux__)
445-
DECL_NPY_SCALAR(long long, NPY_LONG);
446-
#else
447-
DECL_NPY_SCALAR(long, NPY_LONG);
448-
#endif
441+
DECL_NPY_SCALAR(std::int16_t, NPY_INT16);
442+
DECL_NPY_SCALAR(std::int32_t, NPY_INT32);
443+
DECL_NPY_SCALAR(std::int64_t, NPY_INT64);
449444

450445
// unsigned integer types
451-
DECL_NPY_SCALAR(std::uint16_t, NPY_USHORT);
452-
DECL_NPY_SCALAR(std::uint32_t, NPY_UINT);
453-
DECL_NPY_SCALAR(std::uint64_t, NPY_ULONG);
454-
#if defined(__linux__)
455-
DECL_NPY_SCALAR(unsigned long long, NPY_ULONG);
456-
#else
457-
DECL_NPY_SCALAR(unsigned long, NPY_ULONG);
458-
#endif
446+
DECL_NPY_SCALAR(std::uint16_t, NPY_UINT16);
447+
DECL_NPY_SCALAR(std::uint32_t, NPY_UINT32);
448+
DECL_NPY_SCALAR(std::uint64_t, NPY_UINT64);
459449

460450
// floating point types
461451
DECL_NPY_SCALAR(float, NPY_FLOAT);
@@ -819,9 +809,9 @@ struct numpy_scalar {
819809
value_type value;
820810

821811
numpy_scalar() = default;
822-
numpy_scalar(value_type value) : value(value) {}
812+
explicit numpy_scalar(value_type value) : value(value) {}
823813

824-
operator value_type() { return value; }
814+
explicit operator value_type() { return value; }
825815
numpy_scalar &operator=(value_type value) {
826816
this->value = value;
827817
return *this;

0 commit comments

Comments
 (0)