Skip to content

Commit 662ebc8

Browse files
Update test.yml - don't run remote tests for now
Mauricio brought up a valid security risk associated w/ running our e2e integration tests in github CI. --> Removed our github secrets, and therefore need to not run our deployment e2e testing in CI. Signed-off-by: Hillary Sanders <[email protected]>
1 parent dd56a00 commit 662ebc8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ jobs:
5252
# 2 - Deploy this PR to a temp Heroku app and run tests against deployed app (in addition to 'local')
5353
###########################################################################
5454
remote:
55+
if: false # These e2d depployment tests are super useful, but require you to add a HEROKU_API_KEY to your repo's actions secrets.
5556
runs-on: ubuntu-latest
5657
env:
5758
HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
@@ -157,4 +158,4 @@ jobs:
157158
- name: Destroy Heroku app after test
158159
if: always()
159160
run: |
160-
heroku apps:destroy --app $APP_NAME --confirm $APP_NAME
161+
heroku apps:destroy --app $APP_NAME --confirm $APP_NAME

0 commit comments

Comments
 (0)