HHH-19621 Don't render code units for DB2 for i

Author: beikov

hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/DB2iLegacyDialect.java

@@ -9,6 +9,7 @@
 import org.hibernate.boot.model.FunctionContributions;
 import org.hibernate.dialect.DatabaseVersion;
 import org.hibernate.dialect.function.CommonFunctionFactory;
+import org.hibernate.dialect.function.DB2SubstringFunction;
 import org.hibernate.dialect.identity.DB2390IdentityColumnSupport;
 import org.hibernate.dialect.identity.DB2IdentityColumnSupport;
 import org.hibernate.dialect.identity.IdentityColumnSupport;
@@ -57,9 +58,14 @@ public DB2iLegacyDialect(DatabaseVersion version) {
 
 	@Override
 	public void initializeFunctionRegistry(FunctionContributions functionContributions) {
-		super.initializeFunctionRegistry(functionContributions);
+		super.initializeFunctionRegistry( functionContributions );
+		// DB2 for i doesn't allow code units: https://www.ibm.com/docs/en/i/7.1.0?topic=functions-substring
+		functionContributions.getFunctionRegistry().register(
+				"substring",
+				new DB2SubstringFunction( false, functionContributions.getTypeConfiguration() )
+		);
 		if ( getVersion().isSameOrAfter( 7, 2 ) ) {
-			CommonFunctionFactory functionFactory = new CommonFunctionFactory(functionContributions);
+			CommonFunctionFactory functionFactory = new CommonFunctionFactory( functionContributions );
 			functionFactory.listagg( null );
 			functionFactory.inverseDistributionOrderedSetAggregates();
 			functionFactory.hypotheticalOrderedSetAggregates_windowEmulation();

hibernate-core/src/main/java/org/hibernate/dialect/DB2iDialect.java

@@ -8,6 +8,7 @@
 
 import org.hibernate.boot.model.FunctionContributions;
 import org.hibernate.dialect.function.CommonFunctionFactory;
+import org.hibernate.dialect.function.DB2SubstringFunction;
 import org.hibernate.dialect.identity.DB2IdentityColumnSupport;
 import org.hibernate.dialect.identity.DB2zIdentityColumnSupport;
 import org.hibernate.dialect.identity.IdentityColumnSupport;
@@ -61,9 +62,14 @@ protected DatabaseVersion getMinimumSupportedVersion() {
 
 	@Override
 	public void initializeFunctionRegistry(FunctionContributions functionContributions) {
-		super.initializeFunctionRegistry(functionContributions);
+		super.initializeFunctionRegistry( functionContributions );
+		// DB2 for i doesn't allow code units: https://www.ibm.com/docs/en/i/7.1.0?topic=functions-substring
+		functionContributions.getFunctionRegistry().register(
+				"substring",
+				new DB2SubstringFunction( false, functionContributions.getTypeConfiguration() )
+		);
 		if ( getVersion().isSameOrAfter( 7, 2 ) ) {
-			CommonFunctionFactory functionFactory = new CommonFunctionFactory(functionContributions);
+			CommonFunctionFactory functionFactory = new CommonFunctionFactory( functionContributions );
 			functionFactory.listagg( null );
 			functionFactory.inverseDistributionOrderedSetAggregates();
 			functionFactory.hypotheticalOrderedSetAggregates_windowEmulation();

hibernate-core/src/main/java/org/hibernate/dialect/function/DB2SubstringFunction.java

@@ -29,14 +29,21 @@
  */
 public class DB2SubstringFunction extends AbstractSqmSelfRenderingFunctionDescriptor {
 
+	private final boolean needsCodeUnit;
+
 	public DB2SubstringFunction(TypeConfiguration typeConfiguration) {
+		this( true, typeConfiguration );
+	}
+
+	public DB2SubstringFunction(boolean needsCodeUnit, TypeConfiguration typeConfiguration) {
 		super(
 				"substring",
 				new ArgumentTypesValidator( StandardArgumentsValidators.between( 2, 4 ), STRING, INTEGER, INTEGER, FunctionParameterType.ANY ),
 				StandardFunctionReturnTypeResolvers.invariant( typeConfiguration.getBasicTypeRegistry().resolve(
 						StandardBasicTypes.STRING ) ),
 				StandardFunctionArgumentTypeResolvers.invariant( typeConfiguration, STRING, INTEGER, INTEGER )
 		);
+		this.needsCodeUnit = needsCodeUnit;
 	}
 
 	@Override
@@ -51,7 +58,7 @@ public void render(
 			sqlAppender.appendSql( ',' );
 			arguments.get( i ).accept( walker );
 		}
-		if ( argumentCount != 4 ) {
+		if ( argumentCount != 4 && needsCodeUnit ) {
 			sqlAppender.appendSql( ",codeunits32" );
 		}
 		sqlAppender.appendSql( ')' );