Skip to content

Conversation

@derektriley
Copy link
Contributor

@derektriley derektriley commented Sep 22, 2025

Description:
TSS Signing Process for Block Hash should be strictly greater than 1/2 of totalWeight instead of current >= 1/3

Related issue(s):

Fixes #21153

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Derek Riley <[email protected]>
@derektriley derektriley added this to the v0.67 milestone Sep 22, 2025
@derektriley derektriley self-assigned this Sep 22, 2025
@derektriley derektriley requested a review from a team as a code owner September 22, 2025 14:07
@lfdt-bot
Copy link

lfdt-bot commented Sep 22, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link

codacy-production bot commented Sep 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 88.89%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (87dda05) 103838 78668 75.76%
Head commit (fef9bcd) 103844 (+6) 78674 (+6) 75.76% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21175) 9 8 88.89%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...a/com/hedera/node/app/hints/impl/HintsContext.java 66.66% 1 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21175   +/-   ##
=========================================
  Coverage     71.84%   71.85%           
- Complexity    24603    24608    +5     
=========================================
  Files          2666     2666           
  Lines        103933   103939    +6     
  Branches      10873    10875    +2     
=========================================
+ Hits          74670    74682   +12     
  Misses        25220    25220           
+ Partials       4043     4037    -6     
Files with missing lines Coverage Δ Complexity Δ
...in/java/com/hedera/node/config/data/TssConfig.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...a/com/hedera/node/app/hints/impl/HintsContext.java 71.13% <66.66%> (-0.30%) 12.00 <0.00> (ø)

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derektriley derektriley requested a review from a team as a code owner September 29, 2025 17:42
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @derektriley! The only comment I have is to make half as a dynamic property.

Signed-off-by: Derek Riley <[email protected]>
@derektriley derektriley requested a review from a team as a code owner September 30, 2025 16:37
thenswan
thenswan previously approved these changes Oct 2, 2025
Copy link
Contributor

@thenswan thenswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hedera-state-validator/src/main/java/com/hedera/statevalidation/parameterresolver/InitUtils.java LGTM

aderevets and others added 3 commits October 22, 2025 09:42
@derektriley derektriley force-pushed the 21153-tss-block-signing-threshold branch from 0f87ff2 to dad5d5e Compare October 22, 2025 13:44
@derektriley derektriley requested a review from a team as a code owner October 22, 2025 13:44
Signed-off-by: Derek Riley <[email protected]>
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than one comment. Thanks @derektriley @aderevets

Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one comment. Thanks @derektriley @aderevets

@derektriley derektriley merged commit d95eed0 into main Oct 23, 2025
57 of 59 checks passed
@derektriley derektriley deleted the 21153-tss-block-signing-threshold branch October 23, 2025 14:49
mxtartaglia-sl pushed a commit that referenced this pull request Nov 3, 2025
Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Co-authored-by: Artem Derevets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSS Signing Process thresholdWeight should be strictly > 1/2 of total weight

8 participants