-
Notifications
You must be signed in to change notification settings - Fork 184
chore: Update TSS Block Signing weight threshold #21175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Derek Riley <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21175 +/- ##
=========================================
Coverage 71.84% 71.85%
- Complexity 24603 24608 +5
=========================================
Files 2666 2666
Lines 103933 103939 +6
Branches 10873 10875 +2
=========================================
+ Hits 74670 74682 +12
Misses 25220 25220
+ Partials 4043 4037 -6
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsContext.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Riley <[email protected]>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsContext.java
Outdated
Show resolved
Hide resolved
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @derektriley! The only comment I have is to make half as a dynamic property.
Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: Derek Riley <[email protected]>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsContext.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsServiceComponent.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsContext.java
Outdated
Show resolved
Hide resolved
thenswan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hedera-state-validator/src/main/java/com/hedera/statevalidation/parameterresolver/InitUtils.java LGTM
Signed-off-by: artemderevets <[email protected]> Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: Derek Riley <[email protected]>
…ck-signing-threshold
0f87ff2 to
dad5d5e
Compare
Signed-off-by: Derek Riley <[email protected]>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/hints/impl/HintsContext.java
Show resolved
Hide resolved
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than one comment. Thanks @derektriley @aderevets
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than one comment. Thanks @derektriley @aderevets
Signed-off-by: Derek Riley <[email protected]> Signed-off-by: artemderevets <[email protected]> Co-authored-by: Artem Derevets <[email protected]>
Description:
TSS Signing Process for Block Hash should be strictly greater than 1/2 of totalWeight instead of current >= 1/3
Related issue(s):
Fixes #21153
Notes for reviewer:
Checklist