Skip to content

Conversation

@rbarker-dev
Copy link
Member

Description

This pull request updates the Rootly integration in both the node-flow-build-application.yaml and zxcron-extended-test-suite.yaml GitHub workflow files. The main goal is to support multiple Rootly services for notifications, improve clarity in workflow outputs, and ensure alerts are sent to all relevant services.

Rootly Integration Improvements:

  • Added support for notifying multiple Rootly services by introducing the ROOTLY_SERVICES variable and updating workflow outputs and alert payloads to use this list. [1] [2] [3] [4]

Workflow Output and Summary Enhancements:

  • Changed workflow outputs from a single service to service-target and services, and updated summary sections to display both the notification target and all relevant services for better visibility. [1] [2]

These changes help ensure that incidents and notifications are correctly routed to all impacted Rootly services and improve the transparency of workflow status reporting.

Related Issue(s)

Closes #21242

Testing

@rbarker-dev rbarker-dev self-assigned this Sep 25, 2025
@rbarker-dev rbarker-dev added the github_actions Pull requests that update Github Actions code. label Sep 25, 2025
@rbarker-dev rbarker-dev linked an issue Sep 25, 2025 that may be closed by this pull request
@lfdt-bot
Copy link

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (335fb2c) 103366 77740 75.21%
Head commit (acc9716) 103366 (+0) 77740 (+0) 75.21% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21246) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21246   +/-   ##
=========================================
  Coverage     71.27%   71.27%           
  Complexity    24229    24229           
=========================================
  Files          2669     2669           
  Lines        103461   103461           
  Branches      10771    10771           
=========================================
  Hits          73742    73742           
  Misses        25675    25675           
  Partials       4044     4044           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbarker-dev rbarker-dev deleted the 21242-split-reporting-between-eu-and-us-rootly-services branch September 26, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github Actions code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split reporting between EU and US rootly services

3 participants