Skip to content

Conversation

@lpetrovic05
Copy link
Contributor

closes #22237

Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 added this to the v0.69 milestone Nov 25, 2025
@lpetrovic05 lpetrovic05 self-assigned this Nov 25, 2025
@lfdt-bot
Copy link

lfdt-bot commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Signed-off-by: Lazar Petrovic <[email protected]>
s
Signed-off-by: Lazar Petrovic <[email protected]>
@lpetrovic05 lpetrovic05 requested review from abies and poulok November 25, 2025 13:59
@lpetrovic05 lpetrovic05 marked this pull request as ready for review November 25, 2025 13:59
@lpetrovic05 lpetrovic05 requested a review from a team as a code owner November 25, 2025 13:59
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #22316      +/-   ##
============================================
- Coverage     71.00%   70.98%   -0.03%     
+ Complexity    24755    24753       -2     
============================================
  Files          2709     2709              
  Lines        105698   105713      +15     
  Branches      11130    11132       +2     
============================================
- Hits          75047    75036      -11     
- Misses        26581    26604      +23     
- Partials       4070     4073       +3     
Files with missing lines Coverage Δ Complexity Δ
...m/swirlds/platform/consensus/AncestorIterator.java 95.18% <100.00%> (+0.81%) 16.00 <0.00> (+2.00)
...ain/java/com/swirlds/platform/consensus/DeGen.java 85.71% <100.00%> (-5.20%) 5.00 <2.00> (-1.00)

... and 12 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Nov 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (85f2e92) 105601 79071 74.88%
Head commit (f40d462) 105616 (+15) 79063 (-8) 74.86% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22316) 19 19 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

abies
abies previously approved these changes Nov 25, 2025
# Conflicts:
#	platform-sdk/swirlds-platform-core/src/test/java/com/swirlds/platform/consensus/LocalConsensusGenerationTest.java
@abies abies merged commit e8021b7 into main Dec 3, 2025
132 of 134 checks passed
@abies abies deleted the 22237-MOP-AncestorSearch-DeGen branch December 3, 2025 12:35
petreze pushed a commit that referenced this pull request Dec 4, 2025
Signed-off-by: Lazar Petrovic <[email protected]>
Co-authored-by: Artur Biesiadowski <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MOP ancestor search & DeGen

4 participants